Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS plan tries to enable ownership when it's already enabled #582

Closed
quentinmit opened this issue Jul 18, 2023 · 1 comment · Fixed by #623
Closed

macOS plan tries to enable ownership when it's already enabled #582

quentinmit opened this issue Jul 18, 2023 · 1 comment · Fixed by #623
Assignees
@Hoverbear
Labels
bug Something isn't working MacOS Darwin/MacOS
Milestone
0.12.0

Comments

@quentinmit
Copy link

The enable_ownership action appears to check the value of GlobalPermissionsEnabled, and runs diskutil enableOwnership when it's true. But that's backwards; true indicates that ownership is already enabled.

For some reason, diskutil enableOwnership fails on my machine when the volume already has ownership enabled, so I can't actually finish the install as a result.
@Hoverbear Hoverbear added this to the 0.10.1 milestone Jul 19, 2023
@Hoverbear Hoverbear self-assigned this Jul 19, 2023
@Hoverbear Hoverbear added bug Something isn't working MacOS Darwin/MacOS labels Jul 19, 2023
@Hoverbear
Copy link
Contributor

Thanks for this report! I'll take a look.

@Hoverbear Hoverbear modified the milestones: 0.11.0, 0.11.1 Aug 10, 2023
@Hoverbear Hoverbear mentioned this issue Sep 7, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hoverbear Hoverbear

Labels
bug Something isn't working MacOS Darwin/MacOS
Projects
None yet
Milestone
0.12.0
Development

Successfully merging a pull request may close this issue.

Uninvert EnableOwnership logic DeterminateSystems/nix-installer
2 participants
@quentinmit @Hoverbear