Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plist use to the CreateFstabEntry action #221

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Add plist use to the CreateFstabEntry action #221

merged 1 commit into from
Feb 1, 2023

Conversation

Hoverbear
Copy link
Contributor

Description

@9999years pointed out in #217 we could use -plist!

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@Hoverbear Hoverbear self-assigned this Feb 1, 2023
@Hoverbear Hoverbear added the MacOS Darwin/MacOS label Feb 1, 2023
@Hoverbear Hoverbear added this to the v0.2.0 milestone Feb 1, 2023
@Hoverbear Hoverbear requested a review from cole-h February 1, 2023 18:27
cole-h
cole-h approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. This sparks joy.

@Hoverbear Hoverbear merged commit 8042ac5 into main Feb 1, 2023
@Hoverbear Hoverbear deleted the plist-in-diskutil-info branch February 1, 2023 18:40
@lucperkins lucperkins mentioned this pull request Feb 20, 2023
Merged
@lucperkins lucperkins mentioned this pull request Jun 16, 2023
Merged
This was referenced May 23, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

Assignees

@Hoverbear Hoverbear

Labels
MacOS Darwin/MacOS
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Hoverbear @cole-h