Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify the apfs volume doesn't already exist before trying to create it #217

Merged
merged 3 commits into from
Feb 1, 2023
Merged

Verify the apfs volume doesn't already exist before trying to create it #217

merged 3 commits into from
Feb 1, 2023

Conversation

Hoverbear
Copy link
Contributor

@Hoverbear Hoverbear commented Jan 31, 2023 •
edited
Loading

Description

During the plan phase, determine if a Mac APFS volume exists, and error if so with some remedy.

I think @9999years bumped into this in #213 (comment).

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@Hoverbear Hoverbear self-assigned this Jan 31, 2023
@Hoverbear Hoverbear added this to the v0.2.0 milestone Jan 31, 2023
@Hoverbear Hoverbear added the MacOS Darwin/MacOS label Jan 31, 2023
@Hoverbear Hoverbear mentioned this pull request Feb 1, 2023
Merged
6 tasks
@Hoverbear Hoverbear requested a review from cole-h February 1, 2023 18:28
cole-h
cole-h approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Hoverbear Hoverbear merged commit fd149ee into main Feb 1, 2023
@Hoverbear Hoverbear deleted the hoverbear/ds-646-check-if-apfs-volume-exists-during-plan branch February 1, 2023 18:40
@Hoverbear Hoverbear mentioned this pull request Feb 2, 2023
Closed
3 tasks
@lucperkins lucperkins mentioned this pull request Feb 20, 2023
Merged
@lucperkins lucperkins mentioned this pull request Jun 16, 2023
Merged
This was referenced May 23, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@9999years 9999years 9999years left review comments

@cole-h cole-h cole-h approved these changes

Assignees

@Hoverbear Hoverbear

Labels
MacOS Darwin/MacOS
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Hoverbear @9999years @cole-h