Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--extra-conf doesn't add newline with some (all?) options #717

Closed
winterqt opened this issue Nov 11, 2023 · 1 comment · Fixed by #719
Closed

--extra-conf doesn't add newline with some (all?) options #717

winterqt opened this issue Nov 11, 2023 · 1 comment · Fixed by #719
Assignees

Comments

@winterqt
Copy link

Given the following invocation of the installer:

$ curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/branch/main | sh -s -- install macos --no-confirm --extra-conf 'trusted-users = admin'

The generated Nix configuration file looks like:

# Generated by https://github.com/DeterminateSystems/nix-installer.
# See `/nix/nix-installer --version` for the version details.trusted-users = admin
build-users-group = nixbld
experimental-features = nix-command flakes repl-flake
bash-prompt-prefix = (nix:$name)\040
max-jobs = auto
extra-nix-path = nixpkgs=flake:nixpkgs

This would seemingly also cause the sandbox = false example in the README to not work.

@grahamc
Copy link
Member

grahamc commented Nov 11, 2023 via email

grahamc added a commit that referenced this issue Nov 12, 2023
grahamc added a commit that referenced this issue Nov 12, 2023
Otherwise the extra-config option will get swallowed.

Closes #717
@Hoverbear Hoverbear assigned Hoverbear and grahamc and unassigned Hoverbear Nov 14, 2023
Hoverbear pushed a commit that referenced this issue Nov 14, 2023
* Nix config: add extra newlines after the initial comment

Otherwise the extra-config option will get swallowed.

Closes #717

* Push individual strs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants