-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--extra-conf
doesn't add newline with some (all?) options
#717
Comments
Almost definitely a regression from when i replaced the version number in the comment with a generic instruction. Shoot. Thank you! I’m glad this isn’t released yet.
Graham
On Sat, Nov 11, 2023, at 2:06 PM, Winter wrote:
Given the following invocation of the installer:
$ curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/branch/main | sh -s -- install macos --no-confirm --extra-conf 'trusted-users = admin'
The generated Nix configuration file looks like:
`# Generated by https://github.com/DeterminateSystems/nix-installer.
# See `/nix/nix-installer --version` for the version details.trusted-users = admin
build-users-group = nixbld
experimental-features = nix-command flakes repl-flake
bash-prompt-prefix = (nix:$name)\040
max-jobs = auto
extra-nix-path = nixpkgs=flake:nixpkgs
`
… This would seemingly also cause the `sandbox = false` example in the README to not work.
—
Reply to this email directly, view it on GitHub <#717>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAASXLHEUZEHJTYLGZ25S2TYD7EDRAVCNFSM6AAAAAA7HOFEAGVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE4DSMBYGM4DOMY>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
grahamc
added a commit
that referenced
this issue
Nov 12, 2023
grahamc
added a commit
that referenced
this issue
Nov 12, 2023
Otherwise the extra-config option will get swallowed. Closes #717
6 tasks
Hoverbear
pushed a commit
that referenced
this issue
Nov 14, 2023
* Nix config: add extra newlines after the initial comment Otherwise the extra-config option will get swallowed. Closes #717 * Push individual strs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Given the following invocation of the installer:
The generated Nix configuration file looks like:
This would seemingly also cause the
sandbox = false
example in the README to not work.The text was updated successfully, but these errors were encountered: