Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nix config: add extra newlines after the initial comment #719

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Nov 12, 2023

Otherwise the extra-config option will get swallowed.

Closes #717

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

Otherwise the extra-config option will get swallowed.

Closes #717
@grahamc grahamc marked this pull request as ready for review November 12, 2023 04:42
@Hoverbear Hoverbear added this to the 0.14.1 milestone Nov 14, 2023
@Hoverbear Hoverbear merged commit 0c01adc into main Nov 14, 2023
13 checks passed
@Hoverbear Hoverbear deleted the close/717 branch November 14, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--extra-conf doesn't add newline with some (all?) options
3 participants