Check if all states are covered #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed statevars() functions; added all state-related function to states.jl
also fix sbm+1d floodplain test to ensure required states are provided
verseve
requested changes
Feb 19, 2024
There was a problem hiding this comment.
Looks overall good to me. Some code suggestions, mainly related to argument types, dispatch and couple of typos. Nice addition of extra tests for this functionality!
Another general suggestion is to reformat the code after the review if multiple files without code changes (for the PR) are affected. This makes it easier to check what has been changed as part of the PR 😃.
Co-Authored-By: Willem van Verseveld <[email protected]>
|
Thanks for the review, and good suggestions! I have included them all in the latest version. And sorry for creating a messy PR with the formatting changes, I will pay attention to that next time ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
Fixes #293
Explanation
Explain how you addressed the bug/feature request, what choices you made and why.
Checklist
masterAdditional Notes (optional)
Add any additional notes or information that may be helpful.