Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if all states are provided when using reinit=false #293

Closed
2 tasks done
JoostBuitink opened this issue Jul 13, 2023 · 1 comment · Fixed by #359
Closed
2 tasks done

Check if all states are provided when using reinit=false #293

JoostBuitink opened this issue Jul 13, 2023 · 1 comment · Fixed by #359
Assignees
@JoostBuitink
Labels
hydrology Feature or improvement related to the hydrological (vertical) component user-experience Improvements to the settings file, logging, error handling, etc.
Milestone
2024 - Q1

Comments

@JoostBuitink
Copy link
Contributor

JoostBuitink commented Jul 13, 2023 •
edited
Loading

Wflow version checks

  • I have checked that this issue has not already been reported.
  • I have checked that this bug exists on the latest version of Wflow.

Reproducible Example

If you start a wflow_sbm model with glacier=true, and don't pass the glacierstore in the state section, there is no error (or warning thrown.

Current behaviour

See above

Desired behaviour

When using reinit=false, it might be worth that Wflow checks whether all expected states are provided by the instate file. If not, at least a warning should be thrown (and perhaps even an error).

Additional Context

No response
@JoostBuitink JoostBuitink added bug Something isn't working hydrology Feature or improvement related to the hydrological (vertical) component priority labels Jul 13, 2023
@JoostBuitink JoostBuitink self-assigned this Jul 14, 2023
@JoostBuitink JoostBuitink changed the title Glacierstore is not considered as statevars Check if all states are provided when using reinit=false Jul 14, 2023
@JoostBuitink JoostBuitink added user-experience Improvements to the settings file, logging, error handling, etc. and removed priority bug Something isn't working labels Jul 14, 2023
@JoostBuitink
Copy link
Contributor Author

Same as #61

@alimeshgi alimeshgi added this to the Q4 milestone Oct 10, 2023
@JoostBuitink JoostBuitink mentioned this issue Dec 22, 2023
Open
@alimeshgi alimeshgi modified the milestones: Q4, 2024 - Q1 Feb 1, 2024
@JoostBuitink JoostBuitink mentioned this issue Feb 13, 2024
Merged
5 tasks
@verseve verseve mentioned this issue Feb 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoostBuitink JoostBuitink

Labels
hydrology Feature or improvement related to the hydrological (vertical) component user-experience Improvements to the settings file, logging, error handling, etc.
Projects
None yet
Milestone
2024 - Q1
Development

Successfully merging a pull request may close this issue.

glacier_state Deltares/Wflow.jl
Check if all states are covered Deltares/Wflow.jl
2 participants
@JoostBuitink @alimeshgi