Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

47 make single public function for havengetallen #48

Merged
merged 10 commits into from
Jun 8, 2024

Conversation

veenstrajelmer
Copy link
Collaborator

No description provided.

@veenstrajelmer veenstrajelmer linked an issue Jun 8, 2024 that may be closed by this pull request
4 tasks
@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2024

Codecov Report

Attention: Patch coverage is 22.58065% with 24 lines in your changes missing coverage. Please review.

Project coverage is 18.07%. Comparing base (7723cf8) to head (5098dbf).

Files Patch % Lines
kenmerkendewaarden/havengetallen.py 23.52% 13 Missing ⚠️
kenmerkendewaarden/gemiddeldgetij.py 21.42% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   17.97%   18.07%   +0.09%     
==========================================
  Files           8        8              
  Lines         890      902      +12     
==========================================
+ Hits          160      163       +3     
- Misses        730      739       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Jun 8, 2024

Quality Gate Passed Quality Gate passed

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@veenstrajelmer veenstrajelmer merged commit 90d48ff into main Jun 8, 2024
4 checks passed
@veenstrajelmer veenstrajelmer deleted the 47-make-single-public-function-for-havengetallen branch June 8, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make single public function for havengetallen
2 participants