Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make single public function for havengetallen #47

Closed
4 tasks done
veenstrajelmer opened this issue Jun 8, 2024 · 0 comments · Fixed by #48
Closed
4 tasks done

make single public function for havengetallen #47

veenstrajelmer opened this issue Jun 8, 2024 · 0 comments · Fixed by #48

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Jun 8, 2024

  • single public function
  • use this also in gemgetij, so there is no dependency on files
  • properly format docstring of kenmerkendewaarden.gemiddeldgetij.gemiddeld_getij_av_sp_np, now it looks messy in sphinx docs
  • fix havengetallen so we can use old results/figures as validation again >> not possible, also oldest functions in hatyan and old datasets give the same results, something probably has changed a long time ago.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant