Add pronouns to crew manifest #2647
Merged
+65
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
S: Needs Review
Changes: C#
Lyndomen
previously approved these changes
Jan 8, 2025
|
niiiiice. VERY much looking forward to this becoming real edit: very minor nitpick: i think pronoun text being smaller AND italicized looks a little weird, but i have no meaningful suggestions for improving it |
|
thorn of dreams is so back |
deltanedas
requested changes
Jan 8, 2025
|
How does this work with Agent ID? |
My understanding is that the Agent ID isn't supposed to affect the manifest. Double checked, and confirmed, that it doesn't change the manifest.
|
deltanedas
requested changes
Jan 8, 2025
deltanedas
approved these changes
Jan 8, 2025
Thanks for clearing that up. |
|
Oh for future Impstation PRs we should indicate it came from them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Changes the crew manifest so that there is a small pronoun label next to each crew member's name, as well as tweaks the manifest to use box containers to dynamically size.
Why / Balance
This makes it easier to tell what someone's pronouns are when you haven't had a chance to shift-click them, or otherwise don't have a way to identify their pronouns. Per the original PR for impstation, this change also made it so that long names and titles won't overlap.
Technical details
This is just a PR for the cherry-picked commit from impstation. No additional changes have been made. I have tested the cherry-picked commit against the Delta-V codebase.
Media
Crew manifest showing different genders:
Crew manifest with a long name set by an admin:
Crew manifest with a long job title set in the ID computer:
Crew manifest as seen in the lobby:
Requirements
Breaking changes
No identified breaking changes.
Changelog
🆑 TGRCDev