Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routes & folder cleanup #11

Merged
merged 3 commits into from
Jul 26, 2016
Merged

Routes & folder cleanup #11

merged 3 commits into from
Jul 26, 2016

Conversation

michael-martin
Copy link
Contributor

  • Swap back to JSX route definitions
  • Simplify creation of pages (A simple folder under route for each page, which should amalgamate the relevant pieces from components for the current page)
  • Moves /images/ into /static/
  • Delete some starter kit boilerplate

<Route path="/" component={CoreLayout}>
<IndexRoute component={Home} />
</Route>
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vitkon
Copy link
Contributor

vitkon commented Jul 26, 2016

can we clean up async reducers in the same PR as it's all part of the same code splitting boilerplate?

@michael-martin
Copy link
Contributor Author

I'd rather merge this and get an end-to-end feature in place, then come back later to look at the async reducers. We have the issue raised to tackle it

(Just pretty conscious that getting in a first example feature is holding up some of the other PRs too. We'll get to the async piece by Thursday?)

@vitkon
Copy link
Contributor

vitkon commented Jul 26, 2016

OK, lgtm then

@michael-martin michael-martin merged commit ce36e99 into master Jul 26, 2016
@michael-martin michael-martin deleted the RoutesCleanup branch July 26, 2016 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants