You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As part of #11 , I have cleaned up our structure a little.
The idea being that most of our app lives under Components, and each component folder holding all of the related files for that component (the component itself, the stories, the styles etc.)
It leaves the top-level /containers/ folder as something of a sore thumb. Right now it holds AppContainer.js, which just inits the history.
The /containers/ folder is mis-leading if most of our containers are generated by Redux connect() and all live in the /components/ folder
Ducks doesn't have a great recommendation for this either. They split code into containers vs modules (Where a module is essentially a ducks file, a container is from connect() and everything else is under /components/), but we blend those somewhat with our current approach
Thoughts? Should we move AppContainer.js and delete this folder altogether?
The text was updated successfully, but these errors were encountered:
As part of #11 , I have cleaned up our structure a little.
The idea being that most of our app lives under Components, and each component folder holding all of the related files for that component (the component itself, the stories, the styles etc.)
It leaves the top-level
/containers/
folder as something of a sore thumb. Right now it holds AppContainer.js, which just inits the history.The
/containers/
folder is mis-leading if most of our containers are generated by Redux connect() and all live in the/components/
folderDucks doesn't have a great recommendation for this either. They split code into containers vs modules (Where a module is essentially a ducks file, a container is from connect() and everything else is under /components/), but we blend those somewhat with our current approach
Thoughts? Should we move AppContainer.js and delete this folder altogether?
The text was updated successfully, but these errors were encountered: