Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should AppContainer be moved to Components? #12

Open
michael-martin opened this issue Jul 26, 2016 · 1 comment
Open

Should AppContainer be moved to Components? #12

michael-martin opened this issue Jul 26, 2016 · 1 comment
Labels

Comments

@michael-martin
Copy link
Contributor

michael-martin commented Jul 26, 2016

As part of #11 , I have cleaned up our structure a little.

The idea being that most of our app lives under Components, and each component folder holding all of the related files for that component (the component itself, the stories, the styles etc.)

It leaves the top-level /containers/ folder as something of a sore thumb. Right now it holds AppContainer.js, which just inits the history.

The /containers/ folder is mis-leading if most of our containers are generated by Redux connect() and all live in the /components/ folder

Ducks doesn't have a great recommendation for this either. They split code into containers vs modules (Where a module is essentially a ducks file, a container is from connect() and everything else is under /components/), but we blend those somewhat with our current approach

Thoughts? Should we move AppContainer.js and delete this folder altogether?

@vitkon
Copy link
Contributor

vitkon commented Aug 8, 2016

@michael-martin I assume this can be closed now as irrelevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants