-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matthew's autonomous #75
Conversation
… and improved commands on path planner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the paths that are not auto-ruiners:
- You should be able to simultaneously move the arm + drive the robot to speed up the paths. The arm won't actually move that much since its only moving to the subwoofer position, so it shouldn't throw off driving.
- Since the intake command only stops once it detects a note, if you never pick up a note the entire auto would stop. Currently, you follow the path and in parallel run the intake command. If you want the intake command to stop running after the path is done, you could use a
Deadline Group
so the intake command stops when the path is done.
src/main/java/org/carlmontrobotics/commands/AutonRuinerShootAndIntake.java
Show resolved
Hide resolved
src/main/java/org/carlmontrobotics/commands/IntakeAutonRuiner.java
Outdated
Show resolved
Hide resolved
src/main/java/org/carlmontrobotics/commands/AutonRuinerShoot.java
Outdated
Show resolved
Hide resolved
src/main/java/org/carlmontrobotics/subsystems/IntakeShooter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/carlmontrobotics/commands/AutonRuinerShootAndIntake.java
Outdated
Show resolved
Hide resolved
Also, its good to keep the other paths that only do one note, two note, etc. If we're with 254, we don't wanna run into them during auto |
Once PR #68 gets merged, you should merge from master. That should fix the branch-out-of-date and (hopefully) the build failure. |
src/main/java/org/carlmontrobotics/subsystems/IntakeShooter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/carlmontrobotics/subsystems/IntakeShooter.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve this PR. I cannot actually approve this since I'm the author, so someone else please do that for me.
oh wait i can override branch protections haha |
Quoting Matthew