Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matthew's autonomous #75

Merged
merged 16 commits into from
Jun 20, 2024
Merged

Matthew's autonomous #75

merged 16 commits into from
Jun 20, 2024

Conversation

ProfessorAtomicManiac
Copy link
Contributor

@ProfessorAtomicManiac ProfessorAtomicManiac commented Jun 20, 2024

Quoting Matthew

We have a Left Auto Ruiner, Right Auto Ruiner, Center Auto Ruiner, 4 piece Left Auto, 4 Piece Center Auto, 3 Piece Right Auto. These should all hypothetically work given that it does in sim. There are other autos in there but these 6 are probably the main ones we want to use at sunset showdown.

@ProfessorAtomicManiac ProfessorAtomicManiac requested a review from a team as a code owner June 20, 2024 16:34
Copy link
Contributor Author

@ProfessorAtomicManiac ProfessorAtomicManiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the paths that are not auto-ruiners:

  1. You should be able to simultaneously move the arm + drive the robot to speed up the paths. The arm won't actually move that much since its only moving to the subwoofer position, so it shouldn't throw off driving.
  2. Since the intake command only stops once it detects a note, if you never pick up a note the entire auto would stop. Currently, you follow the path and in parallel run the intake command. If you want the intake command to stop running after the path is done, you could use a Deadline Group so the intake command stops when the path is done.

@ProfessorAtomicManiac
Copy link
Contributor Author

ProfessorAtomicManiac commented Jun 20, 2024

Also, its good to keep the other paths that only do one note, two note, etc. If we're with 254, we don't wanna run into them during auto

@brettle
Copy link
Member

brettle commented Jun 20, 2024

Once PR #68 gets merged, you should merge from master. That should fix the branch-out-of-date and (hopefully) the build failure.

Copy link
Contributor Author

@ProfessorAtomicManiac ProfessorAtomicManiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this PR. I cannot actually approve this since I'm the author, so someone else please do that for me.

@ProfessorAtomicManiac
Copy link
Contributor Author

oh wait i can override branch protections haha

@ProfessorAtomicManiac ProfessorAtomicManiac merged commit eb6d89e into master Jun 20, 2024
1 check passed
@ProfessorAtomicManiac ProfessorAtomicManiac deleted the Matthew's-Autonomous branch June 20, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants