Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use lib199 with compliant names for sim devices and data. #68

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Use lib199 with compliant names for sim devices and data. #68

merged 5 commits into from
Jun 20, 2024

Conversation

brettle
Copy link
Member

@brettle brettle commented May 21, 2024

I'll make this ready for review after lib199 PR #94 is merged.

@brettle brettle marked this pull request as ready for review June 20, 2024 21:34
@brettle brettle requested a review from a team as a code owner June 20, 2024 21:34
@brettle brettle enabled auto-merge June 20, 2024 21:34
@brettle brettle mentioned this pull request Jun 20, 2024
Merged
ProfessorAtomicManiac
ProfessorAtomicManiac approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@ProfessorAtomicManiac ProfessorAtomicManiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the changes going on in lib199 regarding sim, but I don't see anything that could break if you are just changing the names.

@brettle brettle merged commit 18e49bf into master Jun 20, 2024
1 check passed
@brettle brettle deleted the fix-use-lib199-with-compliant-sim-names branch June 20, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProfessorAtomicManiac ProfessorAtomicManiac ProfessorAtomicManiac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brettle @ProfessorAtomicManiac