Support for edits #591
Draft
Support for edits #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the pr. It would be great to fix the spelling errors and also add a readme for edits, which can be pretty short in the first iteration, with a 1-2 sentence description of each possible edit. |
|
Spelling should be fixed, documentation will need to be a future thing for now. |
m-reuter
reviewed
Oct 10, 2024
m-reuter
reviewed
Oct 10, 2024
m-reuter
reviewed
Oct 10, 2024
dkuegler
force-pushed
the
feature/edits
branch
from
ad7ed78
to
b24182b
Compare
|
This branch is currently a mess of fixes and features for 6 different things. Those need to be separated into individual branches and PRs. At a minimum, this version seems to work for longitudinal processing (still unclear for edits). |
dkuegler
force-pushed
the
feature/edits
branch
2 times, most recently
from
21f9e19
to
82cd0aa
Compare
m-reuter
force-pushed
the
feature/edits
branch
from
82cd0aa
to
8bccee7
Compare
|
I rebased this to current dev which disentangles the edits from the other changes. Please check :
Also update your local with a hard reset. |
Merged
dkuegler
force-pushed
the
feature/edits
branch
2 times, most recently
from
63ccb88
to
69efedc
Compare
- Adds the --edits flag - Add additional log messages for edits - Support for manedit files for asegdkt_segfile. - Also propagate asegdkt_segfile into aseg_segfile and mask_name recon_surf/recon-surf.sh - Adds the --edits flag - Add additional log messages for edits - Change check for existing run into a message instead a fail criteria in edits mode - Do not delete logfile in edits mode - Make mask and aseg_noCC required for edits mode (otherwise it might get unclear what should or was already done between run_fastsurfer and recon-surf) - Add manedit "search" for mask and aseg_nocc (the latter is recon_surf/talairach-reg.sh - Add an extra argument (new argument #3 to indicate whether talairach.reg should support edits) - Support for edits: some messages and if in edit mode, only run talairach registration if mri/transforms/talairach.xfm and mri/transforms/talairach.auto.xfm are the same (so there are no edits) -- thus edits in talairach.xfm superceed automatic results - talairch-reg.sh will now fail if mri/transforms/talairach.xfm exists, but the script is not running in edits mode (independent if talairach.auto.xfm is the same or not). recon_surf/functions.sh - add the add_file_suffix function, which adds a file suffix (for example manedits) to a file name
dkuegler
force-pushed
the
feature/edits
branch
from
69efedc
to
0000b25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for edits in FastSurfer.
Edits are enabled by the
--editsflag forrun_fastsurfer.sh.Edits supported:
<asegdkt_segfile> via <asegdkt_segfile-w/o-ext>.manedit.
white matter segmentation (wm.mgz) via wm.manedit.mgz
white matter control points (via the standard FreeSurfer control points file)
talairach registration via mri/mri/transforms/talairach.xfm (overwriting talairach registration via mri/mri/transforms/talairach.xfm)
brain.finalsurfs.mgz via brain.finalsurfs.manedit.mgz
This PR also move the allow_root check into functions.sh and introduces run_it and run_it_cmdf function variants that are more clear wrt. argument splitting (see SC2206, SC2207 and similar).