Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some "deep" CRAN errors we needed to resolve that you can see here: https://cran.r-project.org/web/checks/check_results_estimatr.html
lm_robust_helper.cpp
were being used and returned to the R wrapper code and were causing errors in Valgrind. I now initialize these values and tested all of the test files one by one using valgrind and there are no more errors.expect_equal
the max diff of twomargins
was less than < 2e05. I changed the test toexpect_equals
with a tolerance of 0.01. I have no way to test this since rhub's Solaris platform apparently cannot compile RcppEigen files (and I'm not sure if I can fix this). See rhub Solaris fails to compile RcppEigen package r-hub/rhub#109.I think if this passes, we might as well try to resubmit and see what they say?
Oh, I also got rid of my silly way to handle if the cholesky decomposition failed that relied on catching my own error. Logic should be much cleaner now.