Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@vtmn/css, @vtmn/svelte, @vtmn/react, @vtmn/vue): VtmnChip variant input match now the figma specs #1456

Merged
merged 4 commits into from
Aug 4, 2023

Conversation

Tlahey
Copy link
Contributor

@Tlahey Tlahey commented Jul 25, 2023

Changes description

#1455

Expected behaviour
image
Source : https://www.decathlon.design/726f8c765/p/08dbe1-chip/b/50988a

Context

Today, the chip have to be "selected" in order to display the cancel button
image

This PR aim to disable the selected on the variant input and by default, displayed the cancel button

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on related showcases.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Does this introduce a breaking change?

  • No

@Tlahey Tlahey requested review from thibault-mahe and a team as code owners July 25, 2023 14:55
@lauthieb
Copy link
Member

lauthieb commented Aug 1, 2023

Hi @Tlahey, thanks for this contribution!
Can you please confirm that this PR will not cause any breaking change and that we can bump packages with a minor release for each of them?
Thanks 🙏

@lauthieb lauthieb linked an issue Aug 1, 2023 that may be closed by this pull request
@Tlahey
Copy link
Contributor Author

Tlahey commented Aug 3, 2023

Hello @lauthieb
This enhancement will change the behaviour of the VpChip (caus' the select on the input disappears)

We can put a breaking change on the design but the input properties doesn't changed on the component.
The changes are only scoped on the "input" variant

Thus, for me, I think apply a breaking change (for the design part) is a good choice.

@lauthieb
Copy link
Member

lauthieb commented Aug 4, 2023

Thanks @Tlahey for this explanation.
What do you mean about applying a BREAKING CHANGE for design?
You mean bump to major release your changes? Or just in Figma with a communication?
Thank you

@Tlahey
Copy link
Contributor Author

Tlahey commented Aug 4, 2023

Hello @lauthieb
Because the design now match the figma's version, the user who used the VtmnChip with a input variant will have changes when it will upgrade the version.

Selected input is no longer available on this variant
The color of the variant stay white, and no longer has the color blue. So the design will changed for the application.

@lauthieb
Copy link
Member

lauthieb commented Aug 4, 2023

Hi @Tlahey,
Ok, thank you. So, I will merge it with a "BREAKING CHANGE" :)

@lauthieb lauthieb merged commit 8b33064 into main Aug 4, 2023
@lauthieb lauthieb deleted the feat/vtmnChip branch August 4, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: wrong behaviour on the VtmnChip
2 participants