Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: wrong behaviour on the VtmnChip #1455

Closed
Tlahey opened this issue Jul 24, 2023 · 0 comments · Fixed by #1456
Closed

bug: wrong behaviour on the VtmnChip #1455

Tlahey opened this issue Jul 24, 2023 · 0 comments · Fixed by #1456
Assignees
@Tlahey
Labels
bug 🐛 Something isn't working community 👥 As we stopped improvements for this version of Vitamin, this issue needs to be done by the community enhancement 🚀 New feature or request React 🔵 Related to React components library Svelte 🟠 Related to Svelte components library Vue 🟢 Related to Vue components library

Comments

@Tlahey
Copy link
Contributor

Tlahey commented Jul 24, 2023

Today we have wrong behavirous for the chips with 2 variants :

  • input:
    -- Current: it can be selected, and when it is, we see the cross.
    image
    image
    -- Right usage: it can't be selected (blue) and always display the cross
    image
@Tlahey Tlahey added the bug 🐛 Something isn't working label Jul 24, 2023
@Tlahey Tlahey self-assigned this Jul 24, 2023
@Tlahey Tlahey added enhancement 🚀 New feature or request React 🔵 Related to React components library Svelte 🟠 Related to Svelte components library Vue 🟢 Related to Vue components library community 👥 As we stopped improvements for this version of Vitamin, this issue needs to be done by the community labels Jul 24, 2023
@Tlahey Tlahey mentioned this issue Jul 25, 2023
Merged
6 tasks
@lauthieb lauthieb linked a pull request Aug 1, 2023 that will close this issue
feat(@vtmn/css, @vtmn/svelte, @vtmn/react, @vtmn/vue): VtmnChip variant input match now the figma specs #1456
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tlahey Tlahey

Labels
bug 🐛 Something isn't working community 👥 As we stopped improvements for this version of Vitamin, this issue needs to be done by the community enhancement 🚀 New feature or request React 🔵 Related to React components library Svelte 🟠 Related to Svelte components library Vue 🟢 Related to Vue components library
Projects
None yet
Milestone
No milestone
1 participant
@Tlahey