-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactored jellyfish-address
to use a much lighter design
#674
Conversation
Code Climate has analyzed commit 7c70b6a and detected 10 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## main #674 +/- ##
==========================================
+ Coverage 97.57% 97.59% +0.02%
==========================================
Files 140 140
Lines 4166 4245 +79
Branches 519 543 +24
==========================================
+ Hits 4065 4143 +78
- Misses 101 102 +1
Continue to review full report at Codecov.
|
Co-authored-by: Ivan Lee <[email protected]>
7c70b6a
✔️ Deploy Preview for jellyfish-defi ready! 🔨 Explore the source changes: 7c70b6a 🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/614cb057dd26ec00070c54b9 😎 Browse the preview: https://deploy-preview-674--jellyfish-defi.netlify.app |
What kind of PR is this?:
/kind refactor
What this PR does / why we need it:
Implemented an address parser with a simple interface and design, with just 2 main code branches and 4 sub-if branches. The previous implementation has been deprecated but not yet removed to make migration less forceful.
Usage Example:
Which issue(s) does this PR fixes?:
Fixes #239