-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor jellyfish-address
implementation to be lighter
#239
Comments
@fuxingloh: Thanks for opening an issue, it is currently awaiting triage. The triage/accepted label can be added by foundation members by writing /triage accepted in a comment. DetailsI am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository. |
@fuxingloh: There are no 'area' labels on this issue. Adding an appropriate label will greatly expedite the process for us. You can add as many area as you see fit. If you are unsure what to do you can ignore this! You can add area labels by leaving a DetailsI am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository. |
@fuxingloh I am taking this if there is no other more urgent issue. |
Might want to get #244 through ASAP, else you can take this. You might want to do it slowly over a few PRs instead of all at once. The idea is to use deterministic logic to detect with as little logical branches as possible. The logical branch is quite obvious, there should be like 7 or so logical branches. |
What would you like to be added:
Refactoring of
jellyfish-address
code/logic to be lighter, currently, it's too complex. Dangerous technical debt.Why is this needed:
I would expect around
<15
code logical branches forjellyfish-address
but there were+29
which is 10% more than the current combined mono repo code base.#237 has only
+7
for comparison and it has a much more complex implementation design. Clearly, there is much to optimize, the more code there is, the more there is to maintain. Less is more.The text was updated successfully, but these errors were encountered: