Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor jellyfish-address implementation to be lighter #239

Closed
fuxingloh opened this issue May 17, 2021 · 4 comments · Fixed by #674
Closed

refactor jellyfish-address implementation to be lighter #239

fuxingloh opened this issue May 17, 2021 · 4 comments · Fixed by #674
Assignees
Labels
kind/refactor Non feature refactor change triage/accepted Triage has been accepted

Comments

@fuxingloh
Copy link
Contributor

fuxingloh commented May 17, 2021

#189 (review)

What would you like to be added:

Refactoring of jellyfish-address code/logic to be lighter, currently, it's too complex. Dangerous technical debt.

Why is this needed:

@@           Coverage Diff            @@
##             main     #189    +/-   ##
========================================
  Coverage   96.21%   96.22%            
========================================
  Files          66       74     +8     
  Lines        1718     1958   +240     
  Branches      235      264    +29     
========================================
+ Hits         1653     1884   +231     
- Misses         65       74     +9     

I would expect around <15 code logical branches for jellyfish-address but there were +29 which is 10% more than the current combined mono repo code base.

#237 has only +7 for comparison and it has a much more complex implementation design. Clearly, there is much to optimize, the more code there is, the more there is to maintain. Less is more.

@fuxingloh fuxingloh added the kind/feature New feature request label May 17, 2021
@fuxingloh fuxingloh self-assigned this May 17, 2021
@defichain-bot
Copy link
Member

@fuxingloh: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.

@defichain-bot defichain-bot added needs/triage Waiting for triage to be accepted needs/area Needs area label(s) labels May 17, 2021
@defichain-bot
Copy link
Member

@fuxingloh: There are no 'area' labels on this issue. Adding an appropriate label will greatly expedite the process for us. You can add as many area as you see fit. If you are unsure what to do you can ignore this!

You can add area labels by leaving a /area comment.

Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.

@fuxingloh fuxingloh added area/jellyfish-address triage/accepted Triage has been accepted and removed needs/area Needs area label(s) needs/triage Waiting for triage to be accepted labels May 17, 2021
@ivan-zynesis ivan-zynesis self-assigned this May 21, 2021
@ivan-zynesis
Copy link
Contributor

@fuxingloh I am taking this if there is no other more urgent issue.

@fuxingloh
Copy link
Contributor Author

fuxingloh commented May 21, 2021

@fuxingloh I am taking this if there is no other more urgent issue.

Might want to get #244 through ASAP, else you can take this.

You might want to do it slowly over a few PRs instead of all at once. The idea is to use deterministic logic to detect with as little logical branches as possible. The logical branch is quite obvious, there should be like 7 or so logical branches.

@fuxingloh fuxingloh removed their assignment May 21, 2021
@fuxingloh fuxingloh added the kind/refactor Non feature refactor change label May 27, 2021
@defichain-bot defichain-bot removed the kind/feature New feature request label May 27, 2021
@ivan-zynesis ivan-zynesis linked a pull request May 28, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactor Non feature refactor change triage/accepted Triage has been accepted
Projects
None yet
3 participants