Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(packages/jellyfish-api-core): negative interest test #1768

Merged
merged 2 commits into from
Sep 22, 2022

Conversation

DieHard073055
Copy link
Contributor

@DieHard073055 DieHard073055 commented Sep 21, 2022

What this PR does / why we need it:

Fixes for broken negative interest test, which was skipped.

Which issue(s) does this PR fixes?:

Fixes #1763

Additional comments?:

@codeclimate
Copy link

codeclimate bot commented Sep 21, 2022

Code Climate has analyzed commit 376781d and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Sep 21, 2022

Deploy Preview for jellyfishsdk ready!

Name Link
🔨 Latest commit 376781d
🔍 Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/632c1b61df5b450009cc000c
😎 Deploy Preview https://deploy-preview-1768--jellyfishsdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 90.57% // Head: 93.70% // Increases project coverage by +3.12% 🎉

Coverage data is based on head (376781d) compared to base (aa87bff).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1768      +/-   ##
==========================================
+ Coverage   90.57%   93.70%   +3.12%     
==========================================
  Files         359      361       +2     
  Lines       10403    10418      +15     
  Branches     1304     1304              
==========================================
+ Hits         9423     9762     +339     
+ Misses        937      630     -307     
+ Partials       43       26      -17     
Impacted Files Coverage Δ
packages/jellyfish-address/src/script/P2PKH.ts 54.16% <0.00%> (-45.84%) ⬇️
packages/jellyfish-crypto/src/bech32.ts 79.16% <0.00%> (-20.84%) ⬇️
packages/jellyfish-api-core/src/category/mining.ts 84.61% <0.00%> (-15.39%) ⬇️
...ages/jellyfish-api-core/src/category/blockchain.ts 94.59% <0.00%> (-5.41%) ⬇️
...h-transaction-builder/src/txn/txn_builder_vault.ts 76.47% <0.00%> (ø)
packages/jellyfish-wallet-classic/src/classic.ts 100.00% <0.00%> (ø)
packages/jellyfish-wallet-classic/src/index.ts 100.00% <0.00%> (ø)
...s/legacy-api/src/controllers/PoolPairController.ts 85.71% <0.00%> (+1.19%) ⬆️
packages/jellyfish-api-core/src/category/oracle.ts 91.42% <0.00%> (+2.85%) ⬆️
packages/jellyfish-json/src/remap.ts 96.96% <0.00%> (+3.03%) ⬆️
... and 41 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Sep 21, 2022

Docker build preview for jellyfish/apps is ready!

Built with commit 388a995

  • ghcr.io/jellyfishsdk/legacy-api:pr-1768
  • ghcr.io/jellyfishsdk/ocean-api:pr-1768
  • ghcr.io/jellyfishsdk/playground-api:pr-1768
  • ghcr.io/jellyfishsdk/status-api:pr-1768
  • ghcr.io/jellyfishsdk/whale-api:pr-1768

You can also get an immutable image with the commit hash

  • ghcr.io/jellyfishsdk/legacy-api:388a9956812be0d8edc616b3a93b4abcf01f84b1
  • ghcr.io/jellyfishsdk/ocean-api:388a9956812be0d8edc616b3a93b4abcf01f84b1
  • ghcr.io/jellyfishsdk/playground-api:388a9956812be0d8edc616b3a93b4abcf01f84b1
  • ghcr.io/jellyfishsdk/status-api:388a9956812be0d8edc616b3a93b4abcf01f84b1
  • ghcr.io/jellyfishsdk/whale-api:388a9956812be0d8edc616b3a93b4abcf01f84b1

@fuxingloh fuxingloh changed the title Fix negative interest test fix(packages/jellyfish-api-core): negative interest test Sep 22, 2022
@jellyfishsdk-bot jellyfishsdk-bot added the kind/fix Fix a bug label Sep 22, 2022
@fuxingloh fuxingloh merged commit da91eab into main Sep 22, 2022
@fuxingloh fuxingloh deleted the DieHard073055/fix_negative_interest_rate_tests branch September 22, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix skipped test in negativeInterest.test.ts
3 participants