Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix skipped test in negativeInterest.test.ts #1763

Closed
fuxingloh opened this issue Sep 19, 2022 · 1 comment · Fixed by #1768
Closed

fix skipped test in negativeInterest.test.ts #1763

fuxingloh opened this issue Sep 19, 2022 · 1 comment · Fixed by #1768
Assignees
@DieHard073055
Labels
area/packages kind/feature New feature request needs/triage Waiting for triage to be accepted priority/important-soon Will be important soon

Comments

@fuxingloh
Copy link
Contributor

What would you like to be added:

Due to changes in ain v2.11.x release, tests were skipped in negativeInterest.test.ts to keep the PR change brief. We need to fix them.

https://github.com/JellyfishSDK/jellyfish/blob/744e3d8b7251cd928519ac3614610e68a2c908a8/packages/jellyfish-api-core/__tests__/category/loan/negativeInterest.test.ts#L24

https://github.com/JellyfishSDK/jellyfish/blob/744e3d8b7251cd928519ac3614610e68a2c908a8/packages/jellyfish-api-core/__tests__/category/loan/negativeInterest.test.ts#L269

Also when we fix them, we should test the entire vault expect(vault).toStrictEqual({}) instead of expect(vault.field).toStrictEqual('') where we test each field individually.

/area packages
/priority important-soon
/assign @DieHard073055
@fuxingloh fuxingloh added the kind/feature New feature request label Sep 19, 2022
@fuxingloh fuxingloh mentioned this issue Sep 19, 2022
Merged
@jellyfishsdk-bot jellyfishsdk-bot added the needs/triage Waiting for triage to be accepted label Sep 19, 2022
@jellyfishsdk-bot
Copy link
Contributor

@fuxingloh: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the JellyfishSDK developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

fuxingloh added a commit that referenced this issue Sep 19, 2022
@fuxingloh
feat(v2.11): DeFiChain Node v2.11 Release (#1751)
c6a5a4f 
<!--  Thanks for sending a pull request! -->

#### What this PR does / why we need it:

Support for DeFiChain Node `v2.11.1` via custom branch
`defi/defichain:HEAD-02ef6a1b3` due to plenty of breaking issues.

- Corrected Error String to was updated
- Updated test that was "should not ..." and has become "should ..."

Issue opened that need to be addressed:
- #1763
- #1764
@DieHard073055 DieHard073055 mentioned this issue Sep 21, 2022
Merged
fuxingloh pushed a commit that referenced this issue Sep 22, 2022
@DieHard073055
fix(packages/jellyfish-api-core): negative interest test (#1768)
da91eab 
<!--  Thanks for sending a pull request! -->

#### What this PR does / why we need it:

Fixes for broken negative interest test, which was skipped.

#### Which issue(s) does this PR fixes?:

Fixes #1763

#### Additional comments?:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DieHard073055 DieHard073055

Labels
area/packages kind/feature New feature request needs/triage Waiting for triage to be accepted priority/important-soon Will be important soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(packages/jellyfish-api-core): negative interest test DeFiCh/jellyfishsdk
3 participants
@DieHard073055 @fuxingloh @jellyfishsdk-bot