Restore updatemasternode and combine setforcedrewardaddress / removeforcedaddress

[Bushstar]

This PR also changes on the GW fork the stake modifier calculation to use the MN owner address instead of the operator address.

[Stonygan]

Maybe you can check, why its only allowed to use a Legacy or address from the LightWallet(BECH32?) for a rewardaddress? Normal addresses from the APP or CAKE are not allowed? @Bushstar

[mjollnir14]

Very glad to see this feature back. Awesome job guys.

[Bushstar]

@Stonygan I expect that the initial idea was to simplify ownership. P2PKH and P2WPKH are the Legacy and Bech32 address types, these are simple addresses derived from a private key. The other address type you mention is P2SH-P2WPKH which wraps P2WPKH in P2SH, to accept this we have to accept all P2SH addresses and we do not know how those addresses were created, they could be multi-sig or a different type of script entirely. Better to keep things simple than let people get into trouble.

If you have access to the DeFi CLI console you can generate a legacy or bech32 address with the following commands.

getnewaddress "" "legacy"
getnewaddress "" "bech32"

[chanakasameera]

MasternodeInfo.banTx Attribute becomes undefined by this PR, is it acceptable ?
Related jellyfish test : packages/jellyfish-api-core/tests/category/masternode/createMasternode.test.ts

[bvbfan]

Yes, banTx isn't used anywhere, now it's waste of space.

[mjollnir14]

Will this be included in Fort Canning Great World?