Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jellyfish-api-core): Add updatemasternode RPC and fixed fail test #1424

Closed
wants to merge 16 commits into from

Conversation

jingyi2811
Copy link
Contributor

@jingyi2811 jingyi2811 commented May 12, 2022

What this PR does / why we need it:

Restore updatemasternode and also, fix the fail masternode-related test while connecting to the latest docker image.

See DeFiCh/ain#934

Which issue(s) does this PR fixes?:

Fixes

Additional comments?:

@github-actions github-actions bot added area/packages kind/feature New feature request labels May 12, 2022
@codeclimate
Copy link

codeclimate bot commented May 12, 2022

Code Climate has analyzed commit 06f3552 and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented May 12, 2022

Deploy Preview for jellyfishsdk ready!

Name Link
🔨 Latest commit 06f3552
🔍 Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/627e14d48f868f0008757bb3
😎 Deploy Preview https://deploy-preview-1424--jellyfishsdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented May 12, 2022

Docker build preview for jellyfish/apps is ready!

Built with commit 485c951

  • ghcr.io/jellyfishsdk/legacy-api:pr-1424
  • ghcr.io/jellyfishsdk/ocean-api:pr-1424
  • ghcr.io/jellyfishsdk/playground-api:pr-1424
  • ghcr.io/jellyfishsdk/status-api:pr-1424

@jingyi2811 jingyi2811 changed the title feat(jellyfish-api-core): Restore updatemasternode and combine setforcedrewardaddress / removeforcedaddress feat(jellyfish-api-core): Add updatemasternode RPC and fixed fail test May 12, 2022
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #1424 (06f3552) into main (30c8cba) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1424      +/-   ##
==========================================
+ Coverage   89.91%   89.95%   +0.04%     
==========================================
  Files         354      347       -7     
  Lines       10161     9977     -184     
  Branches     1247     1223      -24     
==========================================
- Hits         9136     8975     -161     
+ Misses        976      946      -30     
- Partials       49       56       +7     
Impacted Files Coverage Δ
apps/whale/src/module.api/address.controller.ts 95.74% <ø> (ø)
...ackages/jellyfish-api-core/src/category/account.ts 100.00% <ø> (ø)
...ages/jellyfish-api-core/src/category/masternode.ts 100.00% <ø> (ø)
packages/whale-api-client/src/api/Address.ts 25.00% <ø> (+12.50%) ⬆️
packages/jellyfish-api-core/src/category/loan.ts 96.72% <100.00%> (-3.28%) ⬇️
...es/testcontainers/src/containers/DeFiDContainer.ts 91.11% <100.00%> (ø)
packages/jellyfish-wallet/src/wallet.ts 20.00% <0.00%> (-80.00%) ⬇️
...ransaction-builder/src/txn/txn_builder_liq_pool.ts 42.85% <0.00%> (-57.15%) ⬇️
packages/jellyfish-address/src/p2wsh.ts 48.27% <0.00%> (-51.73%) ⬇️
...nsaction-builder/src/txn/txn_builder_masternode.ts 60.00% <0.00%> (-40.00%) ⬇️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30c8cba...06f3552. Read the comment docs.

@jingyi2811 jingyi2811 closed this May 17, 2022
@jingyi2811 jingyi2811 deleted the jimmy/rpc-updatemasternode branch May 17, 2022 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant