Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: remove json var from oracles test #373

Merged
merged 1 commit into from
May 9, 2021

Conversation

Bushstar
Copy link
Member

@Bushstar Bushstar commented May 9, 2021

No description provided.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@monstrobishi monstrobishi merged commit 6428ac0 into 1.7.x May 9, 2021
@monstrobishi monstrobishi deleted the fix/remove-unused-variables branch May 9, 2021 11:36
@monstrobishi monstrobishi self-requested a review May 9, 2021 11:47
Copy link
Contributor

@monstrobishi monstrobishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

monstrobishi added a commit that referenced this pull request May 24, 2021
* Randomise winning anchor on blockhash (#314)

* Randomise winning anchor on blockhash

* Remove unused function argument

* Lazy rewards redistribution (#279)

* Split custom tx processing into parsing and applying

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

* Prevent copies in serialize

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

* Adopt pool tables to have historical records
Per account rewards calculation

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

* Do not redistribute rewards per block

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

* Fix lint circular dependency

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

* Introduce db version check at runtime

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

* Use bidirectional storage iterators

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

* Fix pool id serialization in update poolpair tx

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

* Update rewards on every block as drop-in replacement

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

* Split pool historical records

* Added EunosHeight

* Fork out rewards redistribution per block

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

* Extend pool swap functional test to Eunos hieght

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

* Minimize undo data size

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

* Prune undo data prior last checkpoint

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

* Prevent database fragmentation

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

* Make account history own database (#323)

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

Co-authored-by: surangap <surangatco@gmail.com>
Co-authored-by: Ahmed Hilali <monstrobishi@gmail.com>

* Split pool reward records (#332)

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

* DFIP8 New emissions (#328)

* New emissions

* Use subsidy map

* Assign swap, futures and options to unallocated

* Show non-UTXO rewards in getblock

* Oracle development (#287)

* Oracle development

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

* Fix rpc parameter not converted in defi-cli (#319)

* Update rpc_oracles.cpp

Fixed rpc documentation

* Updated devnet heights

Co-authored-by: Anthony Fieroni <bvbfan@abv.bg>
Co-authored-by: Ahmed Hilali <monstrobishi@gmail.com>

* Fix compile error (#341)

* Fix build issue on GCC5

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

* Fix unit test fail

* Updated branch matching for dev builds

* Updated dev build branch matching

* Feature/decodecustomtx (#340)

* Added GetBlockHash() function to retrieve the block hash given the transaction hash

* Added new RPC decodecustomtx

* Added tests for decodecustomtx RPC

* Added iswitness parameter to vRPCConvertParams in client.cpp

* Updated decodecustomtx RPC as per new requirements

* Updated decodecustomtx to use INT_MAX as default block height. Updated testing.

* Removed redundant code

* Added GetBlockHash() function to retrieve the block hash given the transaction hash

* Added new RPC decodecustomtx

* Added tests for decodecustomtx RPC

* Added iswitness parameter to vRPCConvertParams in client.cpp

* Updated decodecustomtx RPC as per new requirements

* Updated decodecustomtx to use INT_MAX as default block height. Updated testing.

* Removed redundant code

Co-authored-by: monstrobishi <monstrobishi@gmail.com>

* Extend block merkle root by hash of account changes (#337)

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

Co-authored-by: monstrobishi <monstrobishi@gmail.com>

* spv_getfeerate. SPV wallet fee filter for HTLC. SPV reset on reindex. (#356)

* Added header functions back in to fix compile

* Refactor: RPC oracles take array instead of string (#367)

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

* Track UTXO and tokens sent to burn address (#354)

* Track TX and non-TX burns. Zero foundation balances.

* Remove Qt from depends

* Remove unused variables (#372)

* lint: remove unused json (#373)

* Change difficulty adjust period (#378)

* Remove unused GUI support code (#379)

* Use block height when getting last block time for coin-age (#380)

* Added listaccounts RPC pagination test (#376)

* Added listaccounts RPC pagination test
Optimized Account iteration

* Better handle pagination in listaccounts

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

Co-authored-by: Anthony Fieroni <bvbfan@abv.bg>

* Fix linter error

* Added hardfork heights

* Add creation fee for devnet (#388)

* Masternode creation requires authorization (#386)

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

* Remove backwards compatible anchor code (#383)

* Change daily LP rewards automatically on subsidy reduction (#390)

* Minor lint fixes for 1.7.x (#392)

* Minor lint fix. Set Ubuntu 18.04 as minimum for tests and builds. (#393)

* lint: remove "dead" code

* Run lint on 1.x PRs. Ubuntu 18.04 minimum for tests and builds.

* Fix listaccount pagination after start one (#394)

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

* ICX Orderbook (#335)

* Initial ICX orderbook development

* Inital development of ICX Orderbook

* Fixes and changes.

* Remove prints and small fix.

* Fix seed to hash calculation

* Optimize data structures.

* Fix searching HTLCs.

* Refactor data structures and flow, fixed PR issues

* Refactor data structures and flow, fixed PR issues

* Fix issues.

* Added incentives and fees. Fixed issue with CAmount multiply overflow. Fix tests and clean code. (#5)

* Add incentives and fees. Fix multiply overflow.

* Fix lint rpc mapping check

* Add poolpair id to governance variable for DFI/BTC price used in takerFee, minimum timeout for 2nd HTLC, added initial unit test, various fixes and code clean.

* Fix calculation of takerFee. Clean code.

* Get poolpair id from governance variable.

* Adding expiration for minimum timeout to EXT HTLC.

* Remove locking funds on makeoffer, fixes.

* Add initial test that add creation of poolpair.

* Added takerFeePerBTC gov var, adapted timeouts for htlcs, check in rpc for correct htlc timeouts, added more checks in test.

* Added key for ext htlc closed, addapted test and rpcs.

* Fill partial offer to complete order

* Test burn. Wip burn map in ConnectBlock. Tally tokens.

* ICX Set order owner on creation

* Fix regressions, reproducible crashes
Polish

Fixes: #374

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

* Remove chain data from DB, refactor address storing only in order/offer, fix auth, polish and clean code.

* Add warning disclaimer

* Add creation fee for devnet

* Fixed HTLC timout check, refund partial takerFee on partial offer accept, added test case for BTC/DFI flow, added error test cases, polished code.

* Fixed expiration of offer and htlcs,  added check for open offer on submit htlc, added more test cases.

* Fix order expiration refund, add checkin rpc for htlc if order expires first, fixed and added tests.

* Fix findng poolpair and calculating DFI per BTC, adapted test,  rpc fix.

* Remove unnecessary check in GetBTCDFIPoolPair(), make BTC isDAT in error tests, change BTC blocks in DFI to 20.

* Masternode creation requires authorization (#386)

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

* Polish correct offer prices in blockchain layer

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

* Moving more checks from RPC to mn_checks, cleanup code

* Small fixes.

* Follow getburninfo at all steps. Set correct amounts.

* Fix lint

* Fix lint

* Fix typo.

Co-authored-by: Peter Bushnell <bushsolo@gmail.com>
Co-authored-by: monstrobishi <monstrobishi@gmail.com>
Co-authored-by: Anthony Fieroni <bvbfan@abv.bg>

* Updated Eunos upgrade heights for mainnet and testnet (#391)

* Update chainparams.cpp (#396)

* Ignore but log merkle failures (#403)

* Start burn search from default CScript (#401)

* Skip old coinbase block post Eunos (#400)

* Close expired orders simplifications

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

* Skip higher coinbase spent block post Eunos

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

* Updated code to return correct lastblockcreationattempt in getmininginfo RPC (#399)

* Fixed operator ==

* Update chainparams.cpp

* Add account destruction address on testnet (#404)

* Skip merkle root check on startup (#405)

* Fix/prevent reverts (#408)

* Prevent chain revert past Eunos

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

* Add consesus code to reject custom tx

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

* Fix oracles rpc cli paramters (#409)

* Fix oracles rpc cli paramters

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

* Update oracle input parameter validation

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

* Fix masternode hash generation by adding time to custom tx (#410)

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

* Set new testnet fork height. Revert merkle root checks. (#411)

* Prevent rewards calculation to shown in account history (#412)

Signed-off-by: Anthony Fieroni <bvbfan@abv.bg>

* Add checkpoint to testnet (#414)

* Reduce new fork height to two hours ahead (#415)

* Fix calculating owner rewards and returning takerFee on close offer. (#416)

* Increase masternode registration and resign delay (#419)

* SPV add call, fix Windows connection issue and set Eunos height. (#424)

* SPV getpeers

* SPV: Use non-blocking on Windows

* Set Eunos height on mainnet

* Use C String in peer_log to build on macOS

* Client-name capitalization fix (#425)

* Using ubuntu 18.04 to build for linux (#422)

* Increment PROTOCOL_VERSION (#426)

Co-authored-by: Peter John Bushnell <bushsolo@gmail.com>
Co-authored-by: Anthony Fieroni <bvbfan@abv.bg>
Co-authored-by: surangap <surangatco@gmail.com>
Co-authored-by: Xiao Shengguang <shengguangxiao@gmail.com>
Co-authored-by: Mihailo Milenkovic <mihailo.milenkovic84@gmail.com>
Co-authored-by: U-Zyn Chua <chua@uzyn.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants