Main PR for Eunos: 1.7.x #336

monstrobishi · 2021-04-22T08:34:47Z

What kind of PR is this?:

Main 1.7.x (Eunos) PR.

It's still currently WIP.

/kind feature

Key features:

Interchain Exchange & Bitcoin atomic swap - @Mixa84 ICX Orderbook #335 @Bushstar HTLC set min timeout #364 spv_getfeerate. SPV wallet fee filter for HTLC. SPV reset on reindex. #356 SPV HTLC Consistent key names and descriptions #311 SPV Bitcoin HTLC #308
New emission rate & foundation destruction @Bushstar DFIP8 New emissions #328
Oracle @bvbfan Oracle development #287
Burn tracking - @Bushstar Track UTXO and tokens sent to burn address #354
Lazy block reward calculation for faster block sync. @bvbfan Lazy rewards redistribution #279
Account change tracking in Merkle root - @bvbfan Extend block merkle root by hash of account changes #337

Which issue(s) does this PR fixes?:

Additional comments?:

* Randomise winning anchor on blockhash * Remove unused function argument

* Split custom tx processing into parsing and applying Signed-off-by: Anthony Fieroni <[email protected]> * Prevent copies in serialize Signed-off-by: Anthony Fieroni <[email protected]> * Adopt pool tables to have historical records Per account rewards calculation Signed-off-by: Anthony Fieroni <[email protected]> * Do not redistribute rewards per block Signed-off-by: Anthony Fieroni <[email protected]> * Fix lint circular dependency Signed-off-by: Anthony Fieroni <[email protected]> * Introduce db version check at runtime Signed-off-by: Anthony Fieroni <[email protected]> * Use bidirectional storage iterators Signed-off-by: Anthony Fieroni <[email protected]> * Fix pool id serialization in update poolpair tx Signed-off-by: Anthony Fieroni <[email protected]> * Update rewards on every block as drop-in replacement Signed-off-by: Anthony Fieroni <[email protected]> * Split pool historical records * Added EunosHeight * Fork out rewards redistribution per block Signed-off-by: Anthony Fieroni <[email protected]> * Extend pool swap functional test to Eunos hieght Signed-off-by: Anthony Fieroni <[email protected]> * Minimize undo data size Signed-off-by: Anthony Fieroni <[email protected]> * Prune undo data prior last checkpoint Signed-off-by: Anthony Fieroni <[email protected]> * Prevent database fragmentation Signed-off-by: Anthony Fieroni <[email protected]> * Make account history own database (#323) Signed-off-by: Anthony Fieroni <[email protected]> Co-authored-by: surangap <[email protected]> Co-authored-by: Ahmed Hilali <[email protected]>

Signed-off-by: Anthony Fieroni <[email protected]>

* New emissions * Use subsidy map * Assign swap, futures and options to unallocated * Show non-UTXO rewards in getblock

* Oracle development Signed-off-by: Anthony Fieroni <[email protected]> * Fix rpc parameter not converted in defi-cli (#319) * Update rpc_oracles.cpp Fixed rpc documentation * Updated devnet heights Co-authored-by: Anthony Fieroni <[email protected]> Co-authored-by: Ahmed Hilali <[email protected]>

* Fix build issue on GCC5 Signed-off-by: Anthony Fieroni <[email protected]> * Fix unit test fail

* Added GetBlockHash() function to retrieve the block hash given the transaction hash * Added new RPC decodecustomtx * Added tests for decodecustomtx RPC * Added iswitness parameter to vRPCConvertParams in client.cpp * Updated decodecustomtx RPC as per new requirements * Updated decodecustomtx to use INT_MAX as default block height. Updated testing. * Removed redundant code * Added GetBlockHash() function to retrieve the block hash given the transaction hash * Added new RPC decodecustomtx * Added tests for decodecustomtx RPC * Added iswitness parameter to vRPCConvertParams in client.cpp * Updated decodecustomtx RPC as per new requirements * Updated decodecustomtx to use INT_MAX as default block height. Updated testing. * Removed redundant code Co-authored-by: monstrobishi <[email protected]>

Signed-off-by: Anthony Fieroni <[email protected]> Co-authored-by: monstrobishi <[email protected]>

…#356)

Signed-off-by: Anthony Fieroni <[email protected]>

* Track TX and non-TX burns. Zero foundation balances. * Remove Qt from depends

* lint: remove "dead" code * Run lint on 1.x PRs. Ubuntu 18.04 minimum for tests and builds.

Signed-off-by: Anthony Fieroni <[email protected]>

* Initial ICX orderbook development * Inital development of ICX Orderbook * Fixes and changes. * Remove prints and small fix. * Fix seed to hash calculation * Optimize data structures. * Fix searching HTLCs. * Refactor data structures and flow, fixed PR issues * Refactor data structures and flow, fixed PR issues * Fix issues. * Added incentives and fees. Fixed issue with CAmount multiply overflow. Fix tests and clean code. (#5) * Add incentives and fees. Fix multiply overflow. * Fix lint rpc mapping check * Add poolpair id to governance variable for DFI/BTC price used in takerFee, minimum timeout for 2nd HTLC, added initial unit test, various fixes and code clean. * Fix calculation of takerFee. Clean code. * Get poolpair id from governance variable. * Adding expiration for minimum timeout to EXT HTLC. * Remove locking funds on makeoffer, fixes. * Add initial test that add creation of poolpair. * Added takerFeePerBTC gov var, adapted timeouts for htlcs, check in rpc for correct htlc timeouts, added more checks in test. * Added key for ext htlc closed, addapted test and rpcs. * Fill partial offer to complete order * Test burn. Wip burn map in ConnectBlock. Tally tokens. * ICX Set order owner on creation * Fix regressions, reproducible crashes Polish Fixes: #374 Signed-off-by: Anthony Fieroni <[email protected]> * Remove chain data from DB, refactor address storing only in order/offer, fix auth, polish and clean code. * Add warning disclaimer * Add creation fee for devnet * Fixed HTLC timout check, refund partial takerFee on partial offer accept, added test case for BTC/DFI flow, added error test cases, polished code. * Fixed expiration of offer and htlcs, added check for open offer on submit htlc, added more test cases. * Fix order expiration refund, add checkin rpc for htlc if order expires first, fixed and added tests. * Fix findng poolpair and calculating DFI per BTC, adapted test, rpc fix. * Remove unnecessary check in GetBTCDFIPoolPair(), make BTC isDAT in error tests, change BTC blocks in DFI to 20. * Masternode creation requires authorization (#386) Signed-off-by: Anthony Fieroni <[email protected]> * Polish correct offer prices in blockchain layer Signed-off-by: Anthony Fieroni <[email protected]> * Moving more checks from RPC to mn_checks, cleanup code * Small fixes. * Follow getburninfo at all steps. Set correct amounts. * Fix lint * Fix lint * Fix typo. Co-authored-by: Peter Bushnell <[email protected]> Co-authored-by: monstrobishi <[email protected]> Co-authored-by: Anthony Fieroni <[email protected]>

* Close expired orders simplifications Signed-off-by: Anthony Fieroni <[email protected]> * Skip higher coinbase spent block post Eunos Signed-off-by: Anthony Fieroni <[email protected]>

…nfo RPC (#399)

* Prevent chain revert past Eunos Signed-off-by: Anthony Fieroni <[email protected]> * Add consesus code to reject custom tx Signed-off-by: Anthony Fieroni <[email protected]>

* Fix oracles rpc cli paramters Signed-off-by: Anthony Fieroni <[email protected]> * Update oracle input parameter validation Signed-off-by: Anthony Fieroni <[email protected]>

Signed-off-by: Anthony Fieroni <[email protected]>

…416)

* SPV getpeers * SPV: Use non-blocking on Windows * Set Eunos height on mainnet * Use C String in peer_log to build on macOS

Bushstar and others added 5 commits April 19, 2021 15:26

Randomise winning anchor on blockhash (#314)

776a3a8

* Randomise winning anchor on blockhash * Remove unused function argument

Split pool reward records (#332)

b1d4a65

Signed-off-by: Anthony Fieroni <[email protected]>

DFIP8 New emissions (#328)

5cac2c4

* New emissions * Use subsidy map * Assign swap, futures and options to unallocated * Show non-UTXO rewards in getblock

monstrobishi requested a review from a team as a code owner April 22, 2021 08:34

defichain-bot added the kind/feature label Apr 22, 2021

Bushstar and others added 3 commits April 22, 2021 10:33

Merge branch 'master' into 1.7.x

9e56c69

Fix compile error (#341)

498c3d1

* Fix build issue on GCC5 Signed-off-by: Anthony Fieroni <[email protected]> * Fix unit test fail

Updated branch matching for dev builds

abba965

monstrobishi requested review from a team and fuxingloh April 28, 2021 04:34

monstrobishi and others added 7 commits April 28, 2021 12:35

Updated dev build branch matching

f641b0d

Merge branch 'master' into 1.7.x

76a0241

Merge branch 'master' into 1.7.x

9248e09

Extend block merkle root by hash of account changes (#337)

dd89fc9

Signed-off-by: Anthony Fieroni <[email protected]> Co-authored-by: monstrobishi <[email protected]>

spv_getfeerate. SPV wallet fee filter for HTLC. SPV reset on reindex. (…

d90263e

…#356)

Merge branch 'master' into 1.7.x

f9d277c

uzyn added upgrade labels May 5, 2021

uzyn changed the title ~~[WIP] 1.7.x~~ [WIP] 1.7.x (Eunos) May 5, 2021

uzyn changed the title ~~[WIP] 1.7.x (Eunos)~~ Main PR for Eunos: 1.7.x May 5, 2021

monstrobishi and others added 7 commits May 5, 2021 12:15

Merge branch 'master' into 1.7.x

f6a022d

Added header functions back in to fix compile

19fa508

Merge branch 'master' into 1.7.x

62637f1

Refactor: RPC oracles take array instead of string (#367)

d43f468

Signed-off-by: Anthony Fieroni <[email protected]>

Track UTXO and tokens sent to burn address (#354)

d3f7f45

* Track TX and non-TX burns. Zero foundation balances. * Remove Qt from depends

Remove unused variables (#372)

9526a27

lint: remove unused json (#373)

6428ac0

Bushstar and others added 22 commits May 17, 2021 14:19

Minor lint fix. Set Ubuntu 18.04 as minimum for tests and builds. (#393)

2ac0208

* lint: remove "dead" code * Run lint on 1.x PRs. Ubuntu 18.04 minimum for tests and builds.

Fix listaccount pagination after start one (#394)

8ec5263

Signed-off-by: Anthony Fieroni <[email protected]>

Updated Eunos upgrade heights for mainnet and testnet (#391)

37fc16e

Update chainparams.cpp (#396)

70d3f0d

Ignore but log merkle failures (#403)

c4b569e

Start burn search from default CScript (#401)

5f49bc3

Skip old coinbase block post Eunos (#400)

95a0a10

* Close expired orders simplifications Signed-off-by: Anthony Fieroni <[email protected]> * Skip higher coinbase spent block post Eunos Signed-off-by: Anthony Fieroni <[email protected]>

Updated code to return correct lastblockcreationattempt in getminingi…

4df0cce

…nfo RPC (#399)

Fixed operator ==

0c6aca7

Update chainparams.cpp

1b4f02e

Add account destruction address on testnet (#404)

1dbda83

Skip merkle root check on startup (#405)

7187082

Fix/prevent reverts (#408)

74a0eb3

* Prevent chain revert past Eunos Signed-off-by: Anthony Fieroni <[email protected]> * Add consesus code to reject custom tx Signed-off-by: Anthony Fieroni <[email protected]>

Fix oracles rpc cli paramters (#409)

92841bc

* Fix oracles rpc cli paramters Signed-off-by: Anthony Fieroni <[email protected]> * Update oracle input parameter validation Signed-off-by: Anthony Fieroni <[email protected]>

Fix masternode hash generation by adding time to custom tx (#410)

9dcfc36

Signed-off-by: Anthony Fieroni <[email protected]>

Set new testnet fork height. Revert merkle root checks. (#411)

b9469be

Prevent rewards calculation to shown in account history (#412)

5351e3f

Signed-off-by: Anthony Fieroni <[email protected]>

Add checkpoint to testnet (#414)

8608a58

Reduce new fork height to two hours ahead (#415)

ed8d9ac

Fix calculating owner rewards and returning takerFee on close offer. (#…

ea182fa

…416)

Increase masternode registration and resign delay (#419)

53ea6c2

uzyn previously approved these changes May 24, 2021

View reviewed changes

SPV add call, fix Windows connection issue and set Eunos height. (#424)

060cb63

* SPV getpeers * SPV: Use non-blocking on Windows * Set Eunos height on mainnet * Use C String in peer_log to build on macOS

Bushstar dismissed uzyn’s stale review via 060cb63 May 24, 2021 16:28

uzyn and others added 3 commits May 24, 2021 17:30

Client-name capitalization fix (#425)

3ea3bae

Using ubuntu 18.04 to build for linux (#422)

86f57c2

Increment PROTOCOL_VERSION (#426)

234bbcb

Bushstar approved these changes May 24, 2021

View reviewed changes

monstrobishi merged commit 060a469 into master May 24, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Main PR for Eunos: 1.7.x #336

Main PR for Eunos: 1.7.x #336

monstrobishi commented Apr 22, 2021 •

edited by uzyn

Loading

Main PR for Eunos: 1.7.x #336

Main PR for Eunos: 1.7.x #336

Conversation

monstrobishi commented Apr 22, 2021 • edited by uzyn Loading

What kind of PR is this?:

Key features:

Which issue(s) does this PR fixes?:

Additional comments?:

monstrobishi commented Apr 22, 2021 •

edited by uzyn

Loading