EVM: add input to eth_sendTransaction
#2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
same reason as in DeFiCh#2051
kuegi
force-pushed
the
feature/input-in-ethTx
branch
from
ad0ac67 to
3183d2b
Compare
shohamc1
reviewed
Jun 15, 2023
kuegi
force-pushed
the
feature/input-in-ethTx
branch
from
55b33df to
4d13db2
Compare
shohamc1
approved these changes
Jun 15, 2023
Jouzo
approved these changes
Jun 15, 2023
|
Neat. Thanks @kuegi :) |
canonbrother
pushed a commit
that referenced
this pull request
Jun 19, 2023
* add `input` to eth_sendTransaction same reason as in #2051 * fmt * cleaner way --------- Co-authored-by: Prasanna Loganathar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same as #2051 did it for eth_call, nor also for transactions. as noticed in #2048
Try to use data in transaction request when input is not available. When input is available, data is ignored.
References: