evm: Add input to eth_call
#2051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jouzo
previously approved these changes
Jun 12, 2023
kuegi
reviewed
Jun 12, 2023
|
IMHO input is also needed for a normal SC transaction. web3.js sends it on every txs alongside |
prasannavl
reviewed
Jun 12, 2023
|
Thanks for this catch @kuegi. Yes, This is will amended throughout the usages of Txs in the spec. Just going ahead and merging call part at the moment. |
prasannavl
approved these changes
Jun 12, 2023
kuegi
added a commit
to kuegi/ain
that referenced
this pull request
Jun 14, 2023
same reason as in DeFiCh#2051
prasannavl
added a commit
that referenced
this pull request
Jun 16, 2023
* add `input` to eth_sendTransaction same reason as in #2051 * fmt * cleaner way --------- Co-authored-by: Prasanna Loganathar <[email protected]>
canonbrother
pushed a commit
that referenced
this pull request
Jun 19, 2023
* add `input` to eth_sendTransaction same reason as in #2051 * fmt * cleaner way --------- Co-authored-by: Prasanna Loganathar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to use
datain call request wheninputis not available. Wheninputis available,datais ignored.References:
Fixes #2048