Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand dex fee capability #1118

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Expand dex fee capability #1118

merged 1 commit into from
Feb 25, 2022

Conversation

bvbfan
Copy link
Contributor

@bvbfan bvbfan commented Feb 23, 2022

/kind feature

What this PR does / why we need it:

Current:
/v0/poolpairs/<x>/token_a_fee_pct
/v0/poolpairs/<x>/token_b_fee_pct

new:
/v0/token/<x>/dex_in_fee_pct
/v0/token/<x>/dex_out_fee_pct

Aling with current dex fee variable via poolpairs adding new token variable to handle in/out dex fee
Priority is:

  1. Get poolpair value
  2. Fallback to token value

Fixes #1117

@bvbfan
Expand dex fee capability
85da307 
Signed-off-by: Anthony Fieroni <[email protected]>
@bvbfan bvbfan force-pushed the feature/dexfee_capability branch from da76f89 to 85da307 Compare February 24, 2022 08:20
@Bushstar Bushstar merged commit c6fae3e into v3 Feb 25, 2022
@Bushstar Bushstar deleted the feature/dexfee_capability branch February 25, 2022 06:57
bvbfan added a commit that referenced this pull request Mar 22, 2022
@bvbfan
Expand dex fee capability (#1118)
b4e932f 
Signed-off-by: Anthony Fieroni <[email protected]>
Bushstar pushed a commit that referenced this pull request Mar 22, 2022
@bvbfan
Expand dex fee capability (#1118) (#1153)
0b9f1b5 
Signed-off-by: Anthony Fieroni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcorral dcorral dcorral left review comments

@Bushstar Bushstar Bushstar approved these changes

@uzyn uzyn Awaiting requested review from uzyn

@Mixa84 Mixa84 Awaiting requested review from Mixa84

@surangap surangap Awaiting requested review from surangap

@monstrobishi monstrobishi Awaiting requested review from monstrobishi

Assignees

@bvbfan bvbfan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bvbfan @Bushstar @dcorral @defichain-bot