Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand DEX fee capability #1117

Closed
prasannavl opened this issue Feb 23, 2022 · 1 comment
Closed

Expand DEX fee capability #1117

prasannavl opened this issue Feb 23, 2022 · 1 comment

Comments

@prasannavl
Copy link
Member

Enable pool dex in and dex out are set to the following with the highest priority of these:

=== P1 (Already exists) 
/v0/poolpairs/<x>/token_a_fee_pct
/v0/poolpairs/<x>/token_b_fee_pct

== P2 (New - to be implemented)
/v0/token/<x>/dex_in_fee_pct => Apply to all pools, unless overriden by above.
/v0/token/<x>/dex_out_fee_pct => Apply to all pools, unless overriden by above.

=== Don't see real use case, can skip it for now. 
/v0/poolpairs/global/in_fee_pct => Apply to all pools, unless overriden by above
/v0/poolpairs/global/out_fee_pct => Apply to all pools, unless overriden by above

This enables DEX fees to be set per pool, or per token (to apply to all pools with the token), with per pool taking priority if set.

@defichain-bot
Copy link
Member

@prasannavl: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants