-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Payback of DUSD loan with DFI #1024
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mixa84
requested review from
Bushstar,
bvbfan,
monstrobishi,
surangap and
uzyn
as code owners
January 6, 2022 14:00
bvbfan
suggested changes
Jan 6, 2022
uzyn
suggested changes
Jan 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include unit tests.
kuegi
suggested changes
Jan 6, 2022
solros
reviewed
Jan 7, 2022
solros
reviewed
Jan 7, 2022
bvbfan
previously approved these changes
Jan 19, 2022
bvbfan
previously approved these changes
Jan 19, 2022
kuegi
reviewed
Jan 19, 2022
Bushstar
force-pushed
the
feature/loan_payback_dfi
branch
from
January 20, 2022 11:49
17008e6
to
1e96bee
Compare
bvbfan
previously approved these changes
Jan 21, 2022
prasannavl
changed the title
[WIP] Payback of DUSD loan with DFI
Payback of DUSD loan with DFI
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
It allows to pay back the loan of currently only DUSD in DFI directly (without swapping on DEX to DUSD) on oracle price of DFI/USD.
Which issue(s) does this PR fixes?:
Fixes #999