Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payback of DUSD loan with DFI #1024

Merged
merged 17 commits into from
Jan 24, 2022
Merged

Payback of DUSD loan with DFI #1024

merged 17 commits into from
Jan 24, 2022

Conversation

Mixa84
Copy link
Contributor

@Mixa84 Mixa84 commented Jan 6, 2022

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

It allows to pay back the loan of currently only DUSD in DFI directly (without swapping on DEX to DUSD) on oracle price of DFI/USD.

Which issue(s) does this PR fixes?:

Fixes #999

@Mixa84 Mixa84 added protocol Has network protocol changes wip labels Jan 6, 2022
@Mixa84 Mixa84 requested a review from a team January 6, 2022 14:00
@Mixa84 Mixa84 self-assigned this Jan 6, 2022
src/masternodes/mn_checks.cpp Outdated Show resolved Hide resolved
src/masternodes/mn_checks.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@uzyn uzyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include unit tests.

src/masternodes/masternodes.cpp Outdated Show resolved Hide resolved
@bvbfan bvbfan self-requested a review January 19, 2022 11:45
bvbfan
bvbfan previously approved these changes Jan 19, 2022
bvbfan
bvbfan previously approved these changes Jan 19, 2022
@Bushstar Bushstar force-pushed the feature/loan_payback_dfi branch from 17008e6 to 1e96bee Compare January 20, 2022 11:49
@bvbfan bvbfan self-requested a review January 21, 2022 11:27
bvbfan
bvbfan previously approved these changes Jan 21, 2022
@prasannavl prasannavl changed the title [WIP] Payback of DUSD loan with DFI Payback of DUSD loan with DFI Jan 24, 2022
@prasannavl prasannavl added this to the 2.6.0 - Fort Canning Hill milestone Jan 24, 2022
@prasannavl prasannavl merged commit f0f620e into master Jan 24, 2022
@prasannavl prasannavl deleted the feature/loan_payback_dfi branch January 24, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol Has network protocol changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking Issue for DFI loan payback
8 participants