Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packages/jellyfish-api-core: Add tests for DFI loan payback #960

Closed
surangap opened this issue Jan 11, 2022 · 3 comments · Fixed by #976
Closed

packages/jellyfish-api-core: Add tests for DFI loan payback #960

surangap opened this issue Jan 11, 2022 · 3 comments · Fixed by #976
Assignees
@surangap @chee-chyuan
Labels
area/packages kind/feature New feature request needs/triage Waiting for triage to be accepted sig/blockchain

Comments

@surangap
Copy link
Contributor

What would you like to be added:

Add tests to cover DFI loan payback in packages/jellyfish-api-core/__tests__/category/loan/paybackLoan.test.ts and packages/jellyfish-transaction-builder/__tests__/txn/txn_builder_loan_payback_loan.test.ts
This is to support DeFiCh/ain#1024

Why is this needed:
@surangap surangap added the kind/feature New feature request label Jan 11, 2022
@defichain-bot defichain-bot added the needs/triage Waiting for triage to be accepted label Jan 11, 2022
@defichain-bot
Copy link
Contributor

@surangap: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.

@defichain-bot defichain-bot added the needs/area Needs area label(s) label Jan 11, 2022
@defichain-bot
Copy link
Contributor

@surangap: There are no 'area' labels on this issue. Adding an appropriate label will greatly expedite the process for us. You can add as many area as you see fit. If you are unsure what to do you can ignore this!

You can add area labels by leaving a /area comment.

Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the DeFiCh/oss-governance-bot repository.

@surangap surangap added area/packages and removed needs/triage Waiting for triage to be accepted needs/area Needs area label(s) labels Jan 11, 2022
@defichain-bot defichain-bot added needs/triage Waiting for triage to be accepted labels Jan 11, 2022
@surangap surangap added sig/blockchain and removed needs/triage Waiting for triage to be accepted labels Jan 11, 2022
@defichain-bot defichain-bot added the needs/triage Waiting for triage to be accepted label Jan 11, 2022
@surangap surangap removed the needs/triage Waiting for triage to be accepted label Jan 11, 2022
@defichain-bot defichain-bot added the needs/triage Waiting for triage to be accepted label Jan 11, 2022
@surangap
Copy link
Contributor Author

FCH

@chee-chyuan chee-chyuan mentioned this issue Jan 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@surangap surangap

@chee-chyuan chee-chyuan

Labels
area/packages kind/feature New feature request needs/triage Waiting for triage to be accepted sig/blockchain
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(jellyfish-api-core): add test case for dusd loan payback with dfi BirthdayResearch/jellyfishsdk
3 participants
@surangap @chee-chyuan @defichain-bot