-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement dot operator #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine
src/ui.rs
Outdated
/// update_last_action takes an action, sets the last_action to said action, and returns the Action | ||
fn process_action(&mut self, a: Action) -> Action { | ||
match a { | ||
Action::Quit | Action::ToggleFullscreen | Action::ReRender => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume ToggleFullscreen
is here because it needs to rerender the screen?
Sorry about the merge conflict from #54 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Could you exempt reRendering
from being or resetting last_state
?
That way ToggleFullscreen
can be switched between with .
as well.
My solution may have been hacky. match a {
Action::Quit => {
self.last_action = Action::Noop;
a
}
Action::ReRender => a,
_ => {
self.last_action = a.clone();
a
}
} |
I'm not sure I understand. Are you suggesting that I do what you posted in that last code sample? What does that change? |
On fullscreen switch multiple events which emit So, the
Special casing Rerender to not touch |
Primary internet access is out in my area. So can you merge this?
…On Thu, May 16, 2019, 06:30 Davejkane ***@***.***> wrote:
I'm not sure I understand. Are you suggesting that I do what you posted in
that last code sample? What does that change?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#55?email_source=notifications&email_token=AG5ANRAAJYPDRH2T7NBVEOTPVVAW7A5CNFSM4HNK5URKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVRQUWA#issuecomment-493029976>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AG5ANRGBM4TPWA5OMTQZNILPVVAW7ANCNFSM4HNK5URA>
.
|
This closes #52.