Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destructure event types for less repeating #54

Merged
merged 2 commits into from
May 16, 2019
Merged

Destructure event types for less repeating #54

merged 2 commits into from
May 16, 2019

Conversation

gurgalex
Copy link
Collaborator

@gurgalex gurgalex commented May 16, 2019 •
edited
Loading

Seems much easier to read.
Less typing

Possibly easier to implement #48.

@gurgalex gurgalex requested a review from Davejkane May 16, 2019 09:25
Davejkane
Davejkane approved these changes May 16, 2019
View reviewed changes
Copy link
Owner

@Davejkane Davejkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this is so nice. I had something like this in mind, but I couldn't figure out how to do it. Why do we need the Num keys as no-ops though?

@gurgalex
Copy link
Collaborator Author

Right, had Noop as a placeholder for the State Machine change.

Should I remove the number keys for now?

@gurgalex gurgalex merged commit 4daef01 into Davejkane:development May 16, 2019
@gurgalex gurgalex deleted the ui_event_refactor branch May 16, 2019 11:02
@gurgalex gurgalex mentioned this pull request May 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Davejkane Davejkane Davejkane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gurgalex @Davejkane