Improve performance of adding item to array #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: xiaomianhehe <[email protected]> Date: Tue Feb 18 11:54:23 2020 +0800
| str3 = cJSON_PrintUnformatted(root); | ||
| TEST_ASSERT_EQUAL_STRING(expected_json3, str3); | ||
| free(str3); | ||
|
|
There was a problem hiding this comment.
//To cover more case, add below test would be better?
cJSON_AddItemToArray(array, item1);
cJSON_DeleteItemFromArray(array, 1);
str2 = cJSON_PrintUnformatted(root);
TEST_ASSERT_EQUAL_STRING(expected_json2, str2);
free(str2);
There was a problem hiding this comment.
item1 has been freed during cJSON_DeleteItemFromArray(array, 0);, so I have to copy it at first. besides, I think the test you supplemented won't pass: str2 is not equal expected_json2.
could you provide a completely testcase? or use the insert a suggestion(ctrl+g) to give me a more detail clue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
@xiaomianhehe , would you like to review this pr?