cJSON_DetachItemViaPointer on last item leaves broken list structure

[antcodd]

cJSON_Detach* functions are not working correctly when removing the last item in the list, leaving the item still partially in the object/array. This causes major problems if moving the object to another place in the tree.

It looks like cJSON_DetachItemViaPointer is not clearing parent->child->prev if the item is an array because item->next is NULL when it is the last item in the list.

p *parent
$109 = {next = 0x0, prev = 0x89fde0, child = 0x89fe80, type = 576, valuestring = 0x0, valueint = 0, valuedouble = 0, 
  string = 0x7ffff6a51aac "parent"}

p *parent->child
$110 = {next = 0x89fed0, prev = 0x8a1160, child = 0x0, type = 8, valuestring = 0x0, valueint = 1234, valuedouble = 1234, 
  string = 0x81bc00 "item_one"}

cJSON_DetachItemViaPointer(parent, item_two);

p *parent->child
$111 = {next = 0x89fed0, prev = 0x8a1160, child = 0x0, type = 8, valuestring = 0x0, valueint = 1234, valuedouble = 1234, 
  string = 0x81bc00 "item_one"}

p *parent->child->prev
$112 = {next = 0x0, prev = 0x0, child = 0x0, type = 16, valuestring = 0x8a11b0 "bar", valueint = 0, valuedouble = 0, 
  string = 0x8a11d0 "item_two"}

This may have been introduced by #430?

[Alanscut]

@antcodd Thanks your report and investigation, I will revert PR #430, and try a feasible way to improve this as soon as possible.

[Alanscut]

hi @antcodd , would you mind to review and verify #448 ?

[Alanscut]

fixed by #448