Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[golang] Upgrade go version 1.20 -> 1.21 #2724

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

eliottness
Copy link
Contributor

@eliottness eliottness commented Jul 11, 2024

Motivation

Some CI in dd-trace-go as (still) not passing because system-tests go versions are outdated

Changes

Upgrade go versions

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@eliottness eliottness force-pushed the eliott.bouhana/go-121-again branch from 90ec8f2 to 2302dd5 Compare July 11, 2024 11:08
@eliottness eliottness merged commit 5330ad8 into main Jul 11, 2024
39 checks passed
@eliottness eliottness deleted the eliott.bouhana/go-121-again branch July 11, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code run-parametric-scenario
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants