Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade go-libddwaf & appsec-internal-go and remove occurences of go 1.20 #2782

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

eliottness
Copy link
Contributor

@eliottness eliottness commented Jul 11, 2024

What does this PR do?

  • Upgrade go-libddwaf and appsec-internal-go to their go1.21 version of the go.mod
  • rollout 1.20 from the macrobenchmarks
  • Remove unnecessary files and outdated build tags
  • Upgrade gotraceui

Motivation

Housekeeping & Following the Go Support Policy

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Jul 11, 2024
@eliottness
Copy link
Contributor Author

The parametric tests does not pass because this PR is blocked by DataDog/system-tests#2724

@eliottness eliottness added ci dependencies Pull requests that update a dependency file labels Jul 11, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jul 11, 2024

Benchmarks

Benchmark execution time: 2024-07-11 09:43:23

Comparing candidate commit 537b43a in PR branch eliott.bouhana/housekeeping with baseline commit 577c776 in branch main.

Found 2 performance improvements and 1 performance regressions! Performance is the same for 44 metrics, 0 unstable metrics.

scenario:BenchmarkHttpServeTrace-24

  • 🟥 execution_time [+420.616ns; +497.184ns] or [+2.622%; +3.099%]

scenario:BenchmarkOTelApiWithCustomTags/datadog_otel_api-24

  • 🟩 execution_time [-173.253ns; -149.147ns] or [-3.483%; -2.998%]

scenario:BenchmarkOTelApiWithCustomTags/otel_api-24

  • 🟩 execution_time [-278.922ns; -233.878ns] or [-3.615%; -3.032%]

@eliottness eliottness marked this pull request as ready for review July 11, 2024 12:32
@eliottness eliottness requested review from a team as code owners July 11, 2024 12:32
Copy link
Contributor

@nsrip-dd nsrip-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@eliottness eliottness merged commit e8dc974 into main Jul 11, 2024
191 checks passed
@eliottness eliottness deleted the eliott.bouhana/housekeeping branch July 11, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs ci dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants