fix mesos, consul, docker, parameterize yumrepo sorta #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@flyinprogrammer thanks a lot for adding this. I'll be reviewing this shortly! |
|
Nice! Any update on merging and release this? We're looking for the consul integration support in particular. 😄 |
… polite This will prevent this module from getting up in arms with any other package resource trying to ensure that apt-transport-https is installed
…e default UI If your Puppet infrastructure never fails, let's say because you have a good testing pipeline, it might not be obvious to you that any Puppet events are being reported because everything but failures is 'low' priority. Datadog's web UI defaults to showing only things of 'normal' priority. This changes the priority of a 'changed' resource to 'normal' since a change of configuration is useful information to use when correlating data or showing events in a dashboard.
`name` is a built in parameter in puppet 4, and cannot be used. Renaming `name` to `tag_name` allows puppet 4 to correctly compile the catalog. Also set rspec-puppet to the latest tag. The master branch of rspec-puppet has some issues with the `that_comes_before` method.
…te_integer function.
The minus makes the leading whitespace disappear. Bad yaml!
|
👎 i was afraid of this.... i'll open another PR with just my changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.