Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module has wrong dependency for stdlib in metadata.json #146

Closed
mrunkel opened this issue Nov 19, 2015 · 4 comments
Closed

module has wrong dependency for stdlib in metadata.json #146

mrunkel opened this issue Nov 19, 2015 · 4 comments
Milestone
triage

Comments

@mrunkel
Copy link

mrunkel commented Nov 19, 2015

metadata.json indicates that any 4.x version of stdlib is sufficient, but the use of validate_integer means it's not.

We have 4.5.1 installed currently which doesn't have the validate_integer function.

Please correct your metadata.json file to reflect the minimum version of stdlib that includes validate_integer. It looks like v4.6 is what you want.
@kitchen
Copy link
Contributor

kitchen commented Nov 19, 2015

could you turn this into a PR? :)

mrunkel pushed a commit to mrunkel/puppet-datadog-agent that referenced this issue Nov 21, 2015
Fix for Issue DataDog#146. Require at least v4.6 of stdlib to include…
87fd49b 
… validate_integer function.
@mrunkel mrunkel mentioned this issue Nov 21, 2015
Closed
@mrunkel
Copy link
Author

mrunkel commented Nov 21, 2015

Done.

@truthbk
Copy link
Member

truthbk commented Jan 8, 2016

@mrunkel thanks a lot for this!

@truthbk truthbk added this to the triage milestone Jan 8, 2016
truthbk pushed a commit that referenced this issue Jan 12, 2016
@truthbk
Fix for Issue #146. Require at least v4.6 of stdlib to include valida…
e7437c0 
…te_integer function.
cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this issue Jan 31, 2018
@truthbk
Fix for Issue DataDog#146. Require at least v4.6 of stdlib to include…
c28fa64 
… validate_integer function.
@PolaricEntropy
Copy link

Close this since it's implemented?

@mrunkel mrunkel closed this as completed May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
triage
Development

Successfully merging a pull request may close this issue.

Fix for Issue #146. Require at least v4.6 of stdlib mrunkel/puppet-datadog-agent
4 participants
@kitchen @truthbk @mrunkel @PolaricEntropy