Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: orchestrion fail to instrument if is not in the go.mod folder #466

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

RomainMuller
Copy link
Contributor

Load the configuration from the module root instead of the current working directory, so that it no longer fails when building a package in a sub-directory.

Fixes #464

Load the configuration from the module root instead of the current
working directory, so that it no longer fails when building a package in
a sub-directory.

Fixes #464
@RomainMuller RomainMuller force-pushed the romain.marcadier/build-in-subdir branch from f8d0135 to f610396 Compare December 16, 2024 10:24
@RomainMuller RomainMuller marked this pull request as ready for review December 16, 2024 10:48
@RomainMuller RomainMuller requested a review from a team as a code owner December 16, 2024 10:48
@RomainMuller RomainMuller added this pull request to the merge queue Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.96%. Comparing base (4d4eb9b) to head (322ec8f).

Files with missing lines Patch % Lines
internal/toolexec/aspect/oncompile.go 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #466      +/-   ##
==========================================
- Coverage   63.96%   63.96%   -0.01%     
==========================================
  Files         184      184              
  Lines       11084    11089       +5     
==========================================
+ Hits         7090     7093       +3     
- Misses       3461     3462       +1     
- Partials      533      534       +1     
Components Coverage Δ
Generators 76.15% <ø> (ø)
Instruments 73.41% <ø> (ø)
Go Driver 78.62% <ø> (ø)
Toolexec Driver 74.21% <66.66%> (-0.08%) ⬇️
Aspects 78.75% <ø> (ø)
Injector 77.27% <ø> (ø)
Job Server 67.07% <ø> (ø)
Integration Test Suite 57.48% <ø> (ø)
Other 63.96% <66.66%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
internal/toolexec/aspect/oncompile.go 71.90% <66.66%> (-0.52%) ⬇️

Merged via the queue into main with commit 0e69e71 Dec 16, 2024
38 checks passed
@RomainMuller RomainMuller deleted the romain.marcadier/build-in-subdir branch December 16, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] orchestrion fail to instrument if is not in the go.mod folder
2 participants