Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] orchestrion fail to instrument if is not in the go.mod folder #464

Closed
tonyredondo opened this issue Dec 13, 2024 · 0 comments · Fixed by #466
Closed

[BUG] orchestrion fail to instrument if is not in the go.mod folder #464

tonyredondo opened this issue Dec 13, 2024 · 0 comments · Fixed by #466
Labels
bug Something isn't working

Comments

@tonyredondo
Copy link
Member

tonyredondo commented Dec 13, 2024 •
edited
Loading

Version of orchestrion
orchestrion v1.0.2

Describe what happened:

Orchestrion doesn't instrument if you aren't in the go.mod folder

orchestrion/_integration-tests/civisibility on  main [$?] via 🐹 v1.23.2 on ☁️  [email protected] 
❯ ../../orchestrion go test -tags=integration -shuffle=on ./...                                                          
panic: Orchestrion is not enabled, please run this test with orchestrion

goroutine 1 [running]:
datadoghq.dev/orchestrion/_integration-tests/civisibility.TestMain(...)
	/Users/tony.redondo/repos/github/tonyredondo/orchestrion/_integration-tests/civisibility/main_test.go:30
main.main()
	_testmain.go:61 +0xa4
FAIL	datadoghq.dev/orchestrion/_integration-tests/civisibility	0.416s
FAIL

orchestrion/_integration-tests/civisibility on  main [$?] via 🐹 v1.23.2 on ☁️  [email protected] took 3s 
❯ cd ..

orchestrion/_integration-tests on  main [$?] via 🐹 v1.23.2 on ☁️  [email protected] 
❯ ../orchestrion go test -tags=integration -shuffle=on ./civisibility/...
ok  	datadoghq.dev/orchestrion/_integration-tests/civisibility	4.355s

Describe what you expected:

Test building and passing

Steps to reproduce the issue:

already in the description

Additional environment details (Version of Go, Operating System, etc.):

go version go1.23.2 darwin/arm64
@tonyredondo tonyredondo added the bug Something isn't working label Dec 13, 2024
@tonyredondo tonyredondo changed the title [BUG] [BUG] orchestrion fail to instrument if is not in the go.mod folder Dec 13, 2024
RomainMuller added a commit that referenced this issue Dec 16, 2024
@RomainMuller
fix: orchestrion fail to instrument if is not in the go.mod folder
0f3cb33 
Load the configuration from the module root instead of the current
working directory, so that it no longer fails when building a package in
a sub-directory.

Fixes #464
@RomainMuller RomainMuller mentioned this issue Dec 16, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 16, 2024
@RomainMuller
fix: orchestrion fail to instrument if is not in the go.mod folder (#466
0e69e71 
)

Load the configuration from the module root instead of the current
working directory, so that it no longer fails when building a package in
a sub-directory.

Fixes #464
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: orchestrion fail to instrument if is not in the go.mod folder DataDog/orchestrion
1 participant
@tonyredondo