Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pin): segfault orchestrion.tool.go is not valid go code #407

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

eliottness
Copy link
Contributor

Triggered it on top of #406 because it left the orchestrion.tool.go file empty. And an empty file is not valid go code...

@eliottness eliottness requested a review from a team as a code owner November 20, 2024 13:11
@eliottness eliottness self-assigned this Nov 20, 2024
@RomainMuller RomainMuller added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit 04b4196 Nov 21, 2024
23 checks passed
@RomainMuller RomainMuller deleted the eliottness/pin-segv branch November 21, 2024 19:24
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.32%. Comparing base (49288e7) to head (ee071fa).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
internal/pin/pin.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
- Coverage   60.88%   60.32%   -0.57%     
==========================================
  Files         181      181              
  Lines       12707    12711       +4     
==========================================
- Hits         7737     7668      -69     
- Misses       4439     4535      +96     
+ Partials      531      508      -23     
Components Coverage Δ
Generators 76.72% <ø> (ø)
Instruments 88.05% <ø> (ø)
Go Driver 73.94% <ø> (ø)
Toolexec Driver 70.66% <ø> (ø)
Aspects 71.50% <ø> (ø)
Injector 71.87% <ø> (ø)
Job Server 62.60% <ø> (-5.53%) ⬇️
Integration Test Suite 54.24% <ø> (ø)
Other 60.32% <75.00%> (-0.57%) ⬇️
Files with missing lines Coverage Δ
internal/pin/pin.go 49.25% <75.00%> (+1.53%) ⬆️

... and 5 files with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants