fix(pin): segfault orchestrion.tool.go is not valid go code (#407)

Triggered it on top of #406 because it left the `orchestrion.tool.go` file empty. And an empty file is not valid go code... --------- Signed-off-by: Eliott Bouhana <[email protected]>
DataDog · Nov 21, 2024 · 04b4196 · 04b4196
1 parent 770042c
commit 04b4196
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/internal/pin/pin.go b/internal/pin/pin.go
@@ -63,6 +63,11 @@ func PinOrchestrion(opts Options) error {
 	if errors.Is(err, os.ErrNotExist) {
 		log.Debugf("no %q file found, creating a new one", config.FilenameOrchestrionToolGo)
 		dstFile = defaultOrchestrionToolGo()
+		err = nil
+	}
+
+	if err != nil {
+		return err
 	}
 
 	updateGoGenerateDirective(opts.NoGenerate, dstFile)

diff --git a/internal/pin/pin_test.go b/internal/pin/pin_test.go
@@ -93,6 +93,16 @@ func TestPin(t *testing.T) {
 		assert.NotContains(t, data.Require, goModRequire{"github.com/digitalocean/sample-golang", "v0.0.0-20240904143939-1e058723dcf4"})
 		assert.NotContains(t, data.Require, goModRequire{"github.com/skyrocknroll/go-mod-example", "v0.0.0-20190130140558-29b3c92445e5"})
 	})
+
+	t.Run("empty-tool-dot-go", func(t *testing.T) {
+		tmp := scaffold(t, make(map[string]string))
+		require.NoError(t, os.Chdir(tmp))
+
+		toolDotGo := filepath.Join(tmp, config.FilenameOrchestrionToolGo)
+		require.NoError(t, os.WriteFile(toolDotGo, nil, 0644))
+
+		require.ErrorContains(t, PinOrchestrion(Options{}), "expected 'package', found 'EOF'")
+	})
 }
 
 var goModTemplate = template.Must(template.New("go-mod").Parse(`module github.com/DataDog/orchestrion/pin-test