Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support confluent-kafka-go v1 and v2 #320

Merged
merged 27 commits into from
Nov 5, 2024

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Oct 7, 2024

@rarguelloF rarguelloF changed the title feat: add support for github.com/confluentinc/confluent-kafka-go/kafka WIP: feat: support confluent-kafka-go v1 and v2 Oct 7, 2024
@rarguelloF rarguelloF marked this pull request as ready for review October 8, 2024 20:14
@rarguelloF rarguelloF requested a review from a team as a code owner October 8, 2024 20:14
@rarguelloF rarguelloF changed the title WIP: feat: support confluent-kafka-go v1 and v2 feat: support confluent-kafka-go v1 and v2 Oct 8, 2024
Copy link
Contributor

@RomainMuller RomainMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship only once it references a tagged release of dd-trace-go.

@rarguelloF rarguelloF enabled auto-merge November 5, 2024 13:19
@rarguelloF rarguelloF added this pull request to the merge queue Nov 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 5, 2024
@rarguelloF rarguelloF added this pull request to the merge queue Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 95.13514% with 9 lines in your changes missing coverage. Please review.

Project coverage is 60.50%. Comparing base (bfd6900) to head (020dac6).

Files with missing lines Patch % Lines
...-tests/tests/confluent-kafka-go.v1/skip_windows.go 40.00% 3 Missing ⚠️
...-tests/tests/confluent-kafka-go.v2/skip_windows.go 40.00% 3 Missing ⚠️
...ation-tests/tests/go-elasticsearch/skip_windows.go 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #320      +/-   ##
==========================================
+ Coverage   59.90%   60.50%   +0.59%     
==========================================
  Files         161      165       +4     
  Lines       11691    11871     +180     
==========================================
+ Hits         7004     7182     +178     
- Misses       4189     4193       +4     
+ Partials      498      496       -2     
Components Coverage Δ
Generators 76.98% <ø> (ø)
Instruments 88.05% <ø> (ø)
Go Driver 73.13% <ø> (ø)
Toolexec Driver 70.64% <ø> (ø)
Aspects 71.73% <100.00%> (+0.17%) ⬆️
Injector 73.72% <100.00%> (+0.14%) ⬆️
Job Server 67.56% <ø> (ø)
Integration Test Suite 52.80% <95.10%> (+1.28%) ⬆️
Other 60.50% <95.13%> (+0.59%) ⬆️
Files with missing lines Coverage Δ
...gration-tests/tests/confluent-kafka-go.v1/kafka.go 100.00% <100.00%> (ø)
...gration-tests/tests/confluent-kafka-go.v2/kafka.go 100.00% <100.00%> (ø)
internal/injector/aspect/advice/code/template.go 64.07% <100.00%> (+1.79%) ⬆️
internal/injector/aspect/join/join.go 71.23% <ø> (ø)
...-tests/tests/confluent-kafka-go.v1/skip_windows.go 40.00% <40.00%> (ø)
...-tests/tests/confluent-kafka-go.v2/skip_windows.go 40.00% <40.00%> (ø)
...ation-tests/tests/go-elasticsearch/skip_windows.go 40.00% <25.00%> (ø)

... and 1 file with indirect coverage changes

Merged via the queue into main with commit 3e4604d Nov 5, 2024
23 checks passed
@rarguelloF rarguelloF deleted the rarguellof/APPSEC-53286/support-ckgo branch November 5, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants