Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib/confluentinc/confluent-kafka-go: split tracing code #2907

Merged
merged 11 commits into from
Oct 21, 2024
Merged

contrib/confluentinc/confluent-kafka-go: split tracing code #2907

merged 11 commits into from
Oct 21, 2024

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Oct 3, 2024 •
edited
Loading

What does this PR do?

Refactor confluent-kafka-go kafka so the tracing code can be reused in Orchestrion (DataDog/orchestrion#320)

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Oct 3, 2024
@pr-commenter
Copy link

pr-commenter bot commented Oct 3, 2024 •
edited
Loading

Benchmarks

Benchmark execution time: 2024-10-16 14:21:05

Comparing candidate commit 7f43533 in PR branch rarguelloF/APPSEC-53286/refactor-ckgo-orchestrion with baseline commit 51abc7b in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 0 unstable metrics.

@rarguelloF rarguelloF mentioned this pull request Oct 7, 2024
Merged
@rarguelloF rarguelloF marked this pull request as ready for review October 7, 2024 21:05
@rarguelloF rarguelloF requested review from a team as code owners October 7, 2024 21:05
@darccio darccio mentioned this pull request Oct 9, 2024
Closed
6 tasks
@darccio darccio merged commit 2cae09f into main Oct 21, 2024
144 of 145 checks passed
@darccio darccio deleted the rarguelloF/APPSEC-53286/refactor-ckgo-orchestrion branch October 21, 2024 09:59
darccio added a commit that referenced this pull request Oct 23, 2024
@rarguelloF @darccio
contrib/confluentinc/confluent-kafka-go: split tracing code (#2907)
8736720 
Co-authored-by: Dario Castañé <[email protected]>
github-merge-queue bot pushed a commit to DataDog/orchestrion that referenced this pull request Nov 5, 2024
@rarguelloF @darccio @RomainMuller
feat: support confluent-kafka-go v1 and v2 (#320)
6652139 
Requires: DataDog/dd-trace-go#2907

---------

Co-authored-by: Dario Castañé <[email protected]>
Co-authored-by: Romain Marcadier <[email protected]>
Co-authored-by: Romain Marcadier <[email protected]>
github-merge-queue bot pushed a commit to DataDog/orchestrion that referenced this pull request Nov 5, 2024
@rarguelloF @darccio @RomainMuller
feat: support confluent-kafka-go v1 and v2 (#320)
3e4604d 
Requires: DataDog/dd-trace-go#2907

---------

Co-authored-by: Dario Castañé <[email protected]>
Co-authored-by: Romain Marcadier <[email protected]>
Co-authored-by: Romain Marcadier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomainMuller RomainMuller RomainMuller approved these changes

@darccio darccio darccio approved these changes

Assignees
No one assigned
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rarguelloF @darccio @RomainMuller