Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTEL-1738] Deprecate APMStatsConsumer #320

Merged
merged 4 commits into from
Apr 22, 2024
Merged

[OTEL-1738] Deprecate APMStatsConsumer #320

merged 4 commits into from
Apr 22, 2024

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Apr 19, 2024

APMStatsConsumer is no longer in use since open-telemetry/opentelemetry-collector-contrib#31416.

The only breaking change is users can no longer do consumer.(*Consumer).ConsumeAPMStats(), instead they can do consumer.(*APMStatsConsumer).ConsumeAPMStats(). Everything else is backwards-compatible.

@songy23 songy23 requested a review from mx-psi April 19, 2024 17:30
@songy23 songy23 marked this pull request as ready for review April 19, 2024 17:30
@songy23 songy23 requested a review from a team as a code owner April 19, 2024 17:30
@songy23 songy23 added the breaking-change This PR introduces a Go API breaking change label Apr 19, 2024
.chloggen/deprecate-apm-stats-consumer.yaml Outdated Show resolved Hide resolved
@songy23 songy23 enabled auto-merge (squash) April 22, 2024 13:36
@songy23 songy23 merged commit aafbbc6 into main Apr 22, 2024
7 checks passed
@songy23 songy23 deleted the yang.song/cleanup branch April 22, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This PR introduces a Go API breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants