Remove messages for non-ERROR can_connect service checks #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ofek
requested changes
Aug 16, 2021
ofek
approved these changes
Aug 20, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes messages for status that is not an ERROR for the
*.can_connectservice check.Datadog is removing messages for integration checks that give OK status to reduce the load on the backend. There's a small scenario where
*.can_connectgives a WARNING status along with a message. This WARNING is later converted into an OK, as only OK or ERROR statuses are used for*.can_connect.Once this is merged in, DataDog/integrations-core#9958 can be merged.