Change ignite.total_allocated_pages and ignite.total_allocated_size from monotonic_count to gauge
#9939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
yzhan289
changed the title
ignite.total_allocated_pages and ignite.total_allocated_size from monotonic_count to gauge
ofek
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR replaces
ignite.total_allocated_pagesandignite.total_allocated_sizefrom being monotonic_count to gauge, as the metrics make more sense as gauges.The default dashboard for Ignite does not use either, so this change won't affect the dashboard.
Currently the CI is failing, but it will be fixed once DataDog/jmxfetch#369 is merged in.
Motivation
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached