Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove messages for non-ERROR can_connect service checks #369

Merged
merged 4 commits into from
Aug 24, 2021

Conversation

yzhan289
Copy link
Contributor

@yzhan289 yzhan289 commented Aug 16, 2021

This PR removes messages for status that is not an ERROR for the *.can_connect service check.

Datadog is removing messages for integration checks that give OK status to reduce the load on the backend. There's a small scenario where *.can_connect gives a WARNING status along with a message. This WARNING is later converted into an OK, as only OK or ERROR statuses are used for *.can_connect.

Once this is merged in, DataDog/integrations-core#9958 can be merged.

@yzhan289 yzhan289 requested a review from ofek August 16, 2021 21:31
Copy link
Contributor

@remeh remeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@truthbk truthbk merged commit 3236430 into DataDog:master Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants